New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectMapping.Dynamic property should have ''strict" value #379

Closed

maximpashuk opened this issue Nov 10, 2013 · 0 comments

maximpashuk commented Nov 10, 2013

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-object-type.html
Quote1:
"The dynamic parameter can also be set to strict, meaning that not only new fields will not be introduced into the mapping, parsing (indexing) docs with such new fields will fail."

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-dynamic-mapping.html
Quote2:
"The dynamic creation of fields within a type can be completely disabled by setting the dynamic property of the type to strict"

As you can see in
https://github.com/Mpdreamz/NEST/blob/master/src/Nest/Domain/Mapping/Types/ObjectMapping.cs
Dynamic property of ObjectMapping class has a type nullable bool, which does not allow to set value "strict".

I think some kind of enum should be used instead. Please rewrite Dynamic property of ObjectMapping class

Mpdreamz closed this as completed in

75f4b26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment