Scalar mappings are storing byte as short

[einfoman]

NEST/Elasticsearch.Net version: 7.5

Elasticsearch version: 7

Description of the problem including expected versus actual behavior:
When you use Scalar for mapping of byte-property, field is mapped as short. I guess it is a mistake, isn't?

See

elasticsearch-net/src/Nest/Mapping/Types/Properties-Scalar.cs

Lines 233 to 237 in 8b99472

	public PropertiesDescriptor<T> Scalar(Expression<Func<T, byte>> field, Func<NumberPropertyDescriptor<T>, INumberProperty> selector = null) =>
	SetProperty(selector.InvokeOrDefault(new NumberPropertyDescriptor<T>().Name(field).Type(NumberType.Short)));
	public PropertiesDescriptor<T> Scalar(Expression<Func<T, byte?>> field, Func<NumberPropertyDescriptor<T>, INumberProperty> selector = null) =>
	SetProperty(selector.InvokeOrDefault(new NumberPropertyDescriptor<T>().Name(field).Type(NumberType.Short)));

[russcam]

It's no mistake 😄

A System.Byte is an unsigned integer with a range from 0 to 255. Conversely, a byte in Java, which Elasticsearch is written in, is a signed integer with range -128 to 127. In order to store the full range of System.Byte then, a short field datatype needs to be used. Take a look at #1643 for more info.

[einfoman]

Oops.. Sorry to disturb you

[russcam]

No worries @einfoman, good to check!