ElasticSearch.Net.Exceptions.MaxRetryException hides server error

[crunchie84]

When using Nest 1.0-beta1 + ES 1.1.1 the MaxRetryException gives no usefull information.

The query which we used resulted in a SearchPhaseExecutionException because it was buggy. It took more time then was needed to diagnose because we got MaxRetryExceptions in our logs instead of the underlying exception message from the server.

Expected result: Append server error into MaxRetryException as InnerException.

[Mpdreamz]

hmm this should already be the case, will double check.

[Mpdreamz]

Ahh, SearchPhraseExecution is a server exception and this won't be set as InnerException.

[Mpdreamz]

It will now throw an ElasticsearchServerException which has an ExceptionType and Error property.

In your case ExceptionType would be SearchPhaseExecutionException

By default NEST follows a more c/go like error checking pattern with

var result = call();
if (result.IsValid) result.OriginalException; //this holds a ElasticsearchServerException now;

You can configure NEST to always throw a real exception in this case like so:

var settings = new ConnectionSettings().ThrowOnElasticsearchServerExceptions();

Or Elasticsearch.Net

var settings = new ConnectionConfiguration().ThrowOnElasticsearchServerExceptions();

I'm still debating whether the default should be throw or not (I still want to support both patterns) any input on this is welcome :)

[crunchie84]

I would expect that the default behaviour is based on what kind of exceptionType the server has raised. For instance:

• Retrieving document by id but not found => null response (or IResponse isValid=false)
• parsing of query failed => exception by default