Skip to content

Provide support for filter_path for all apis #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RolfDeVries opened this issue Apr 10, 2024 · 4 comments · Fixed by #8257
Closed

Provide support for filter_path for all apis #8116

RolfDeVries opened this issue Apr 10, 2024 · 4 comments · Fixed by #8257
Labels
8.x Relates to a 8.x client version Area: Client Category: Enhancement

Comments

@RolfDeVries
Copy link

Elastic.Clients.Elasticsearch version:
8.13.5

Elasticsearch version:
N/A

.NET runtime version:
.Net 8.0

Operating system version:
N/A

Description of the problem including expected versus actual behavior:
I'm upgrading from NEST 7.latest to the new Elastic.Clients.Elasticsearch version.
And I'm missing some features that are not yet supported

Steps to reproduce:

  1. Create code to call a random api, any api will do:

    var response = await client.Cluster.StatsAsync(s => s
        .FilterPath(filterPath)
    );
    

Expected behavior
In the NEST 7 version, the FilterPath option was very easy to use
In the Elastic.Client.Elasticsearch 8 there is no support for this, please add it back for performance reasons

Provide ConnectionSettings (if relevant):

Provide DebugInformation (if relevant):

@RolfDeVries RolfDeVries added 8.x Relates to a 8.x client version Category: Bug labels Apr 10, 2024
@flobernd
Copy link
Member

Hi @RolfDeVries,

thanks for reporting. It seems that the FilterPath setting currently is only available for the request classes (e.g. StatsRequest), but not the corresponding descriptors (StatsRequestDescriptor). I'll fix that in one of the next patch releases.

@RolfDeVries
Copy link
Author

Thank you very much!

@RolfDeVries
Copy link
Author

Hi,

Any update on this? This is a blocking issue for migration from 7 to 8 on my projects.

Gr Rolf

@flobernd
Copy link
Member

Hi @RolfDeVries, sorry for the delay. There was a lot of higher priority things to do which caused this issue to drop of my radar. I just created a PR and will publish a new patch release in the next hours 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version Area: Client Category: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants