Skip to content

Missing property SemanticTextProperty.SearchInferenceId #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergey-tihon opened this issue Mar 6, 2025 · 3 comments · Fixed by #8472
Closed

Missing property SemanticTextProperty.SearchInferenceId #8467

sergey-tihon opened this issue Mar 6, 2025 · 3 comments · Fixed by #8472
Labels
8.x Relates to a 8.x client version Area: Specification Category: Bug

Comments

@sergey-tihon
Copy link

sergey-tihon commented Mar 6, 2025

Elastic.Clients.Elasticsearch version: 8.17.1

Elasticsearch version: 8.17.2

.NET runtime version: 9.0

Operating system version: macOS

Description of the problem including expected versus actual behavior:

According to the docs https://www.elastic.co/guide/en/elasticsearch/reference/current/semantic-text.html#semantic-text-params SemanticTextProperty should have both InferenceId and SearchInferenceId properties, but it does not

public sealed partial class SemanticTextProperty : IProperty
{
[JsonInclude, JsonPropertyName("inference_id")]
public Elastic.Clients.Elasticsearch.Id InferenceId { get; set; }
[JsonInclude, JsonPropertyName("meta")]
public IDictionary<string, string>? Meta { get; set; }
[JsonInclude, JsonPropertyName("type")]
public string Type => "semantic_text";
}

Expected behavior

Add new property

	[JsonInclude, JsonPropertyName("search_inference_id")]
	public Elastic.Clients.Elasticsearch.Id SearchInferenceId { get; set; }

p.s. @flobernd appreciate if you can do your magic and regenerate the client using the latest spec.

@sergey-tihon sergey-tihon added 8.x Relates to a 8.x client version Category: Bug labels Mar 6, 2025
@flobernd
Copy link
Member

flobernd commented Mar 6, 2025

Hi @sergey-tihon , thanks for reporting.

It seems like the property is as well missing in the specification. We have to add it there first, before I can regenerate the client.

@sergey-tihon
Copy link
Author

just wonder when next release is planned?

@flobernd
Copy link
Member

@sergey-tihon Early next week 🙂 Ill make sure your fix is included!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version Area: Specification Category: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants