Skip to content

Elasticsearch.Net.Connection.Thrift has unused dependency from package NetReflector #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maximpashuk opened this issue Aug 6, 2014 · 1 comment

Comments

@maximpashuk
Copy link

At nuget.org
https://www.nuget.org/packages/Elasticsearch.Net.Connection.Thrift/
We can see dependency from package NetReflector.

I can found only one line of code that use it
https://github.com/elasticsearch/elasticsearch-net/blob/213eb1a130712af5b821af3062b984ffccd22fdc/src/Connections/Elasticsearch.Net.Connection.Thrift/Transport/TSocketSettings.cs#L5

Class TSocketSettings marked with attribute 'Exortech.NetReflector.ReflectorTypeAttribute'
I can't found any logic that retrieves this attribute and do something with it.
If this attribute not used anymore, please remove it and remove unused nuget dependency.

@gmarz
Copy link
Contributor

gmarz commented Aug 6, 2014

Thanks @maximpashuk. I believe you're right, we didn't need it. Nothing I love more than getting rid of a dependency ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants