Skip to content

Remove client parameter check #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sewi-cpan opened this issue May 16, 2019 · 2 comments
Closed

Remove client parameter check #171

sewi-cpan opened this issue May 16, 2019 · 2 comments
Assignees

Comments

@sewi-cpan
Copy link
Contributor

Please consider removing the client-side parameter checking at all. It's causing lots of trouble with nearly no win (see #169 for example).
Upgrading the client module isn't always as easy as it looks like due to the heavy dependencies.

@ezimuel
Copy link
Contributor

ezimuel commented Mar 12, 2020

@sewi-cpan this is an interesting point, I would like to improve this part. I think it's important to have a feature that provides a check for the parameter since it makes no sense to send a request with an invalid body. I will update elasticsearch-perl on a regular basis and this issue will be mitigated.
I'm investigating also the possibility to have some autocompletion feature with the parameters. Do you have any idea about that? Thanks!

@sewi-cpan
Copy link
Contributor Author

sewi-cpan commented Dec 29, 2022

@ezimuel Problems start when Elasticsearch expects different arguments than the client module. Invalid arguments should usually happen in development. Errors due to invalid arguments are unlikely to happen in production. If they happen, they're very cheap.
The argument check causes serious trouble while switching from one Elasticsearch version to another or using clusters with different major versions (one already upgraded, the other one not upgraded).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants