Skip to content

Mis-named file in 7.711 release #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pghmcfc opened this issue Feb 12, 2021 · 3 comments
Closed

Mis-named file in 7.711 release #202

pghmcfc opened this issue Feb 12, 2021 · 3 comments
Assignees

Comments

@pghmcfc
Copy link

pghmcfc commented Feb 12, 2021

The file lib/Search/Elasticsearch/Client/7_0/Direct/SearchableSnapshots copy.pm should be called lib/Search/Elasticsearch/Client/7_0/Direct/SearchableSnapshots.pm; as it stands, attempts to build the module result in this error:

$ cd Search-Elasticsearch-7.711
$ perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Search::Elasticsearch
$ make -j4
make: *** No rule to make target 'lib/Search/Elasticsearch/Client/7_0/Direct/SearchableSnapshots', needed by 'manifypods'.  Stop.
make: *** Waiting for unfinished jobs....

As a workaround I have renamed the file and changed the references to it in t/author-no-tabs.t, t/author-eol.t and MANIFEST, which is enough to get the module to build and pass its test suite.

@gyarakilaszlo
Copy link

I can confirm this issue, and pghmcfc's workaround is working well.

@ezimuel
Copy link
Contributor

ezimuel commented Feb 25, 2021

Thanks for the alert, this is embarrassing 😥. I'll fix this with the path release 7.11.1.

@ezimuel ezimuel self-assigned this Feb 25, 2021
@ezimuel
Copy link
Contributor

ezimuel commented Mar 1, 2021

Fixed with 7.11.1 patch release.

@ezimuel ezimuel closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants