Skip to content

[docs] verify_certs is True by default but documented as False #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ypid-geberit opened this issue Jun 7, 2018 · 1 comment
Closed

Comments

@ypid-geberit
Copy link

ypid-geberit commented Jun 7, 2018

There is a mismatch between docs and implementation:

# make sure we verify SSL certificates (off by default)

use_ssl=False, verify_certs=True, ca_certs=None, client_cert=None,

At first I was scared about the bad default value of verify_certs=False but happy it is only the docs that are wrong 😉

@fxdgear
Copy link
Contributor

fxdgear commented Jun 25, 2018

Ahh ok there's actually a disconnect between requests and urllib3. Because off by default is what we get in urllib3. I'll clean up the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants