[CLIENT] Added support for the ignore parameter in all API calls

Author: karmi

elasticsearch-transport/lib/elasticsearch/transport/transport/base.rb

@@ -244,6 +244,10 @@ def perform_request(method, path, params={}, body=nil, &block)
           start = Time.now if logger || tracer
           tries = 0
 
+          params = params.clone
+
+          ignore = Array(params.delete(:ignore)).compact.map { |s| s.to_i }
+
           begin
             tries     += 1
             connection = get_connection or raise Error.new("Cannot get new connection from pool.")
@@ -309,7 +313,9 @@ def perform_request(method, path, params={}, body=nil, &block)
             __log    method, path, params, body, url, response, nil, 'N/A', duration if logger
             __trace  method, path, params, body, url, response, nil, 'N/A', duration if tracer
             __log_failed response if logger
-            __raise_transport_error response
+
+            # Swallow the exception when the `ignore` parameter matches response status
+            __raise_transport_error response unless ignore.include?(response.status.to_i)
           end
 
           json     = serializer.load(response.body) if response.body && !response.body.empty? && response.headers && response.headers["content-type"] =~ /json/

elasticsearch-transport/test/integration/client_test.rb

@@ -53,6 +53,14 @@ class Elasticsearch::Transport::ClientIntegrationTest < Elasticsearch::Test::Int
       end
     end
 
+    should "ignore specified response codes" do
+      response = @client.perform_request 'GET', '/_foobar', ignore: 400
+      assert_equal 400, response.status
+
+      assert_instance_of Hash, response.body
+      assert_match /illegal_argument_exception/, response.body.inspect
+    end
+
     should "pass options to the transport" do
       @client = Elasticsearch::Client.new \
         host: "127.0.0.1:#{@port}",

elasticsearch-transport/test/unit/transport_base_test.rb

@@ -246,6 +246,21 @@ def initialize(*); end
       end
     end
 
+    should "not raise an error when the :ignore argument has been passed" do
+      @transport.stubs(:get_connection).returns(stub_everything :failures => 1)
+
+      assert_raise Elasticsearch::Transport::Transport::Errors::BadRequest do
+        @transport.perform_request 'GET', '/' do
+          Elasticsearch::Transport::Transport::Response.new 400, 'CLIENT ERROR'
+        end
+      end
+
+      # No `BadRequest` error
+      @transport.perform_request 'GET', '/', :ignore => 400 do
+        Elasticsearch::Transport::Transport::Response.new 400, 'CLIENT ERROR'
+      end
+    end
+
     should "mark the connection as dead on failure" do
       c = stub_everything :failures => 1
       @transport.expects(:get_connection).returns(c)