Skip to content

Commit 06cf4ba

Browse files
authored
Stop reporting missing endpoints as errors (#4031) (#4058)
We have other ways of identifying them. (cherry picked from commit f7edcb5) # Conflicts: # output/schema/validation-errors.json
1 parent e90312b commit 06cf4ba

File tree

2 files changed

+2
-71
lines changed

2 files changed

+2
-71
lines changed

compiler/src/steps/validate-model.ts

+2-11
Original file line numberDiff line numberDiff line change
@@ -215,14 +215,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
215215
return
216216
}
217217

218-
if (endpoint.request == null) {
219-
if (endpoint.response == null) {
220-
modelError('Missing request & response')
221-
return
222-
} else {
223-
modelError('Missing request')
224-
}
225-
} else {
218+
if (endpoint.request !== null) {
226219
const reqType = getTypeDef(endpoint.request)
227220

228221
if (reqType == null) {
@@ -266,9 +259,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
266259

267260
setRootContext(endpoint.name, 'response')
268261

269-
if (endpoint.response == null) {
270-
modelError('Missing response')
271-
} else {
262+
if (endpoint.response !== null) {
272263
const respType = getTypeDef(endpoint.response)
273264

274265
if (respType == null) {

output/schema/validation-errors.json

-60
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@
1313
],
1414
"response": []
1515
},
16-
"capabilities": {
17-
"request": [
18-
"Missing request & response"
19-
],
20-
"response": []
21-
},
2216
"cat.aliases": {
2317
"request": [
2418
"Request: query parameter 'master_timeout' does not exist in the json spec",
@@ -182,30 +176,6 @@
182176
],
183177
"response": []
184178
},
185-
"connector.secret_delete": {
186-
"request": [
187-
"Missing request & response"
188-
],
189-
"response": []
190-
},
191-
"connector.secret_get": {
192-
"request": [
193-
"Missing request & response"
194-
],
195-
"response": []
196-
},
197-
"connector.secret_post": {
198-
"request": [
199-
"Missing request & response"
200-
],
201-
"response": []
202-
},
203-
"connector.secret_put": {
204-
"request": [
205-
"Missing request & response"
206-
],
207-
"response": []
208-
},
209179
"create": {
210180
"request": [
211181
"Request: query parameter 'if_primary_term' does not exist in the json spec",
@@ -232,24 +202,6 @@
232202
],
233203
"response": []
234204
},
235-
"fleet.delete_secret": {
236-
"request": [
237-
"Missing request & response"
238-
],
239-
"response": []
240-
},
241-
"fleet.get_secret": {
242-
"request": [
243-
"Missing request & response"
244-
],
245-
"response": []
246-
},
247-
"fleet.post_secret": {
248-
"request": [
249-
"Missing request & response"
250-
],
251-
"response": []
252-
},
253205
"get_source": {
254206
"request": [
255207
"Request: query parameter 'stored_fields' does not exist in the json spec"
@@ -303,12 +255,6 @@
303255
],
304256
"response": []
305257
},
306-
"inference.put_mistral": {
307-
"request": [
308-
"Missing request & response"
309-
],
310-
"response": []
311-
},
312258
"ingest.delete_geoip_database": {
313259
"request": [
314260
"Request: query parameter 'master_timeout' does not exist in the json spec",
@@ -419,12 +365,6 @@
419365
],
420366
"response": []
421367
},
422-
"transform.get_node_stats": {
423-
"request": [
424-
"Missing request & response"
425-
],
426-
"response": []
427-
},
428368
"transform.get_transform": {
429369
"request": [],
430370
"response": [

0 commit comments

Comments
 (0)