[7.x] Remove ML system_annotations_retention_days setting

droberts195 · sethmlarson · commit 8ae626f341c1 · 2021-08-06T17:17:34.000-05:00
This is a reversion of #522. We decided not to add a new setting after all, but to use results_retention_days for both results and system annotations (on the basis that system annotations are a type of result). This setting has been added and removed within the 7.15 development cycle so there are no implications for anyone using released product.
diff --git a/output/schema/schema.json b/output/schema/schema.json
@@ -105393,17 +105393,6 @@
               "namespace": "_types"
             }
           }
-        },
-        {
-          "name": "system_annotations_retention_days",
-          "required": false,
-          "type": {
-            "kind": "instance_of",
-            "type": {
-              "name": "long",
-              "namespace": "_types"
-            }
-          }
         }
       ]
     },
@@ -105652,17 +105641,6 @@
               "namespace": "_types"
             }
           }
-        },
-        {
-          "name": "system_annotations_retention_days",
-          "required": false,
-          "type": {
-            "kind": "instance_of",
-            "type": {
-              "name": "long",
-              "namespace": "_types"
-            }
-          }
         }
       ]
     },
@@ -114261,18 +114239,6 @@
                 "namespace": "_types"
               }
             }
-          },
-          {
-            "description": "Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.",
-            "name": "system_annotations_retention_days",
-            "required": false,
-            "type": {
-              "kind": "instance_of",
-              "type": {
-                "name": "long",
-                "namespace": "_types"
-              }
-            }
           }
         ]
       },
@@ -114529,17 +114495,6 @@
                 "namespace": "_types"
               }
             }
-          },
-          {
-            "name": "system_annotations_retention_days",
-            "required": false,
-            "type": {
-              "kind": "instance_of",
-              "type": {
-                "name": "long",
-                "namespace": "_types"
-              }
-            }
           }
         ]
       },
@@ -115852,18 +115807,6 @@
                 "namespace": "ml._types"
               }
             }
-          },
-          {
-            "description": "Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.",
-            "name": "system_annotations_retention_days",
-            "required": false,
-            "type": {
-              "kind": "instance_of",
-              "type": {
-                "name": "long",
-                "namespace": "_types"
-              }
-            }
           }
         ]
       },
diff --git a/output/typescript/types.ts b/output/typescript/types.ts
@@ -10717,7 +10717,6 @@ export interface MlJob {
   renormalization_window_days?: long
   results_index_name: IndexName
   results_retention_days?: long
-  system_annotations_retention_days?: long
 }
 
 export interface MlJobBlocked {
@@ -10745,7 +10744,6 @@ export interface MlJobConfig {
   renormalization_window_days?: long
   results_index_name?: IndexName
   results_retention_days?: long
-  system_annotations_retention_days?: long
 }
 
 export interface MlJobForecastStatistics {
@@ -11752,7 +11750,6 @@ export interface MlPutJobRequest extends RequestBase {
     renormalization_window_days?: long
     results_index_name?: IndexName
     results_retention_days?: long
-    system_annotations_retention_days?: long
   }
 }
 
@@ -11777,7 +11774,6 @@ export interface MlPutJobResponse {
   renormalization_window_days?: long
   results_index_name: string
   results_retention_days?: long
-  system_annotations_retention_days?: long
 }
 
 export interface MlPutTrainedModelRequest extends RequestBase {
@@ -11934,7 +11930,6 @@ export interface MlUpdateJobRequest extends RequestBase {
     groups?: string[]
     detectors?: MlDetector[]
     per_partition_categorization?: MlPerPartitionCategorization
-    system_annotations_retention_days?: long
   }
 }
 
diff --git a/specification/ml/_types/Job.ts b/specification/ml/_types/Job.ts
@@ -67,7 +67,6 @@ export class Job {
   renormalization_window_days?: long
   results_index_name: IndexName
   results_retention_days?: long
-  system_annotations_retention_days?: long
 }
 
 export class JobConfig {
@@ -88,7 +87,6 @@ export class JobConfig {
   renormalization_window_days?: long
   results_index_name?: IndexName
   results_retention_days?: long
-  system_annotations_retention_days?: long
 }
 export class JobStats {
   assignment_explanation?: string
diff --git a/specification/ml/put_job/MlPutJobRequest.ts b/specification/ml/put_job/MlPutJobRequest.ts
@@ -104,9 +104,5 @@ export interface Request extends RequestBase {
      * Advanced configuration option. The period of time (in days) that results are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), results that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all results are retained.
      */
     results_retention_days?: long
-    /**
-     * Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.
-     */
-    system_annotations_retention_days?: long
   }
 }
diff --git a/specification/ml/put_job/MlPutJobResponse.ts b/specification/ml/put_job/MlPutJobResponse.ts
@@ -48,6 +48,5 @@ export class Response {
     renormalization_window_days?: long
     results_index_name: string
     results_retention_days?: long
-    system_annotations_retention_days?: long
   }
 }
diff --git a/specification/ml/update_job/MlUpdateJobRequest.ts b/specification/ml/update_job/MlUpdateJobRequest.ts
@@ -89,9 +89,5 @@ export interface Request extends RequestBase {
      * Settings related to how categorization interacts with partition fields.
      */
     per_partition_categorization?: PerPartitionCategorization
-    /**
-     * Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.
-     */
-    system_annotations_retention_days?: long
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -105393,17 +105393,6 @@`
`105393`	`105393`	`"namespace": "_types"`
`105394`	`105394`	`}`
`105395`	`105395`	`}`
`105396`		`- },`
`105397`		`- {`
`105398`		`- "name": "system_annotations_retention_days",`
`105399`		`- "required": false,`
`105400`		`- "type": {`
`105401`		`- "kind": "instance_of",`
`105402`		`- "type": {`
`105403`		`- "name": "long",`
`105404`		`- "namespace": "_types"`
`105405`		`- }`
`105406`		`- }`
`105407`	`105396`	`}`
`105408`	`105397`	`]`
`105409`	`105398`	`},`
`@@ -105652,17 +105641,6 @@`
`105652`	`105641`	`"namespace": "_types"`
`105653`	`105642`	`}`
`105654`	`105643`	`}`
`105655`		`- },`
`105656`		`- {`
`105657`		`- "name": "system_annotations_retention_days",`
`105658`		`- "required": false,`
`105659`		`- "type": {`
`105660`		`- "kind": "instance_of",`
`105661`		`- "type": {`
`105662`		`- "name": "long",`
`105663`		`- "namespace": "_types"`
`105664`		`- }`
`105665`		`- }`
`105666`	`105644`	`}`
`105667`	`105645`	`]`
`105668`	`105646`	`},`
`@@ -114261,18 +114239,6 @@`
`114261`	`114239`	`"namespace": "_types"`
`114262`	`114240`	`}`
`114263`	`114241`	`}`
`114264`		`- },`
`114265`		`- {`
`114266`		- "description": "Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.",
`114267`		`- "name": "system_annotations_retention_days",`
`114268`		`- "required": false,`
`114269`		`- "type": {`
`114270`		`- "kind": "instance_of",`
`114271`		`- "type": {`
`114272`		`- "name": "long",`
`114273`		`- "namespace": "_types"`
`114274`		`- }`
`114275`		`- }`
`114276`	`114242`	`}`
`114277`	`114243`	`]`
`114278`	`114244`	`},`
`@@ -114529,17 +114495,6 @@`
`114529`	`114495`	`"namespace": "_types"`
`114530`	`114496`	`}`
`114531`	`114497`	`}`
`114532`		`- },`
`114533`		`- {`
`114534`		`- "name": "system_annotations_retention_days",`
`114535`		`- "required": false,`
`114536`		`- "type": {`
`114537`		`- "kind": "instance_of",`
`114538`		`- "type": {`
`114539`		`- "name": "long",`
`114540`		`- "namespace": "_types"`
`114541`		`- }`
`114542`		`- }`
`114543`	`114498`	`}`
`114544`	`114499`	`]`
`114545`	`114500`	`},`
`@@ -115852,18 +115807,6 @@`
`115852`	`115807`	`"namespace": "ml._types"`
`115853`	`115808`	`}`
`115854`	`115809`	`}`
`115855`		`- },`
`115856`		`- {`
`115857`		- "description": "Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.",
`115858`		`- "name": "system_annotations_retention_days",`
`115859`		`- "required": false,`
`115860`		`- "type": {`
`115861`		`- "kind": "instance_of",`
`115862`		`- "type": {`
`115863`		`- "name": "long",`
`115864`		`- "namespace": "_types"`
`115865`		`- }`
`115866`		`- }`
`115867`	`115810`	`}`
`115868`	`115811`	`]`
`115869`	`115812`	`},`
Original file line number	Diff line number	Diff line change
`@@ -10717,7 +10717,6 @@ export interface MlJob {`
`10717`	`10717`	`renormalization_window_days?: long`
`10718`	`10718`	`results_index_name: IndexName`
`10719`	`10719`	`results_retention_days?: long`
`10720`		`- system_annotations_retention_days?: long`
`10721`	`10720`	`}`
`10722`	`10721`
`10723`	`10722`	`export interface MlJobBlocked {`
`@@ -10745,7 +10744,6 @@ export interface MlJobConfig {`
`10745`	`10744`	`renormalization_window_days?: long`
`10746`	`10745`	`results_index_name?: IndexName`
`10747`	`10746`	`results_retention_days?: long`
`10748`		`- system_annotations_retention_days?: long`
`10749`	`10747`	`}`
`10750`	`10748`
`10751`	`10749`	`export interface MlJobForecastStatistics {`
`@@ -11752,7 +11750,6 @@ export interface MlPutJobRequest extends RequestBase {`
`11752`	`11750`	`renormalization_window_days?: long`
`11753`	`11751`	`results_index_name?: IndexName`
`11754`	`11752`	`results_retention_days?: long`
`11755`		`- system_annotations_retention_days?: long`
`11756`	`11753`	`}`
`11757`	`11754`	`}`
`11758`	`11755`
`@@ -11777,7 +11774,6 @@ export interface MlPutJobResponse {`
`11777`	`11774`	`renormalization_window_days?: long`
`11778`	`11775`	`results_index_name: string`
`11779`	`11776`	`results_retention_days?: long`
`11780`		`- system_annotations_retention_days?: long`
`11781`	`11777`	`}`
`11782`	`11778`
`11783`	`11779`	`export interface MlPutTrainedModelRequest extends RequestBase {`
`@@ -11934,7 +11930,6 @@ export interface MlUpdateJobRequest extends RequestBase {`
`11934`	`11930`	`groups?: string[]`
`11935`	`11931`	`detectors?: MlDetector[]`
`11936`	`11932`	`per_partition_categorization?: MlPerPartitionCategorization`
`11937`		`- system_annotations_retention_days?: long`
`11938`	`11933`	`}`
`11939`	`11934`	`}`
`11940`	`11935`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ export class Job {`
`67`	`67`	`renormalization_window_days?: long`
`68`	`68`	`results_index_name: IndexName`
`69`	`69`	`results_retention_days?: long`
`70`		`- system_annotations_retention_days?: long`
`71`	`70`	`}`
`72`	`71`
`73`	`72`	`export class JobConfig {`
`@@ -88,7 +87,6 @@ export class JobConfig {`
`88`	`87`	`renormalization_window_days?: long`
`89`	`88`	`results_index_name?: IndexName`
`90`	`89`	`results_retention_days?: long`
`91`		`- system_annotations_retention_days?: long`
`92`	`90`	`}`
`93`	`91`	`export class JobStats {`
`94`	`92`	`assignment_explanation?: string`
Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,5 @@ export interface Request extends RequestBase {`
`104`	`104`	`* Advanced configuration option. The period of time (in days) that results are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), results that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all results are retained.`
`105`	`105`	`*/`
`106`	`106`	`results_retention_days?: long`
`107`		`- /**`
`108`		- * Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.
`109`		`- */`
`110`		`- system_annotations_retention_days?: long`
`111`	`107`	`}`
`112`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,5 @@ export class Response {`
`48`	`48`	`renormalization_window_days?: long`
`49`	`49`	`results_index_name: string`
`50`	`50`	`results_retention_days?: long`
`51`		`- system_annotations_retention_days?: long`
`52`	`51`	`}`
`53`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,5 @@ export interface Request extends RequestBase {`
`89`	`89`	`* Settings related to how categorization interacts with partition fields.`
`90`	`90`	`*/`
`91`	`91`	`per_partition_categorization?: PerPartitionCategorization`
`92`		`- /**`
`93`		- * Advanced configuration option. The period of time (in days) that automatically created annotations are retained. Age is calculated relative to the timestamp of the latest bucket result. If this property has a non-null value, once per day at 00:30 (server time), annotations that are the specified number of days older than the latest bucket result are deleted from Elasticsearch. The default value is null, which means all annotations are retained. User created annotations are never deleted automatically.
`94`		`- */`
`95`		`- system_annotations_retention_days?: long`
`96`	`92`	`}`
`97`	`93`	`}`