Allow some statement attributes be used for a connection (#213)

* allow some statment attrs be used for a connection

Allow two statment attributes be used on a connection handle.

This is in support of some 2.x applications that can make use of them.
- SQL_ATTR_MAX_ROWS: the value is reset to 0 if different, which is the
same behavior the driver has when the attribute is set on a statement;
- SQL_ATTR_QUERY_TIMEOUT: the attribute is applied; any statement
belonging to the affected connection can subsequently override the
value, so the support is safe.

* comment better the code

Rephrase comment to reflect extra case inclusion and justify lack of a
"break;".

Author: bpintea

driver/connect.c

@@ -3255,7 +3255,9 @@ SQLRETURN EsSQLSetConnectAttrW(
 			RET_HDIAGS(dbc, SQL_STATE_HY092);
 			break;
 
-		/* coalesce login and connection timeouts for a REST req. */
+		/* coalesce login, connection and query timeouts for a REST req. */
+		case SQL_ATTR_QUERY_TIMEOUT: /* stmt attr -- 2.x */
+			WARNH(dbc, "applying a statement as connection attribute (2.x?)");
 		case SQL_ATTR_CONNECTION_TIMEOUT:
 		case SQL_ATTR_LOGIN_TIMEOUT:
 			INFOH(dbc, "setting login/connection timeout: %lu",
@@ -3302,10 +3304,17 @@ SQLRETURN EsSQLSetConnectAttrW(
 			RET_HDIAGS(DBCH(ConnectionHandle), SQL_STATE_HY092);
 #endif
 
+		case SQL_ATTR_MAX_ROWS: /* stmt attr -- 2.x app */
+			WARNH(dbc, "applying a statement as connection attribute (2.x?)");
+			DBGH(dbc, "setting max rows: %llu.", (SQLULEN)Value);
+			if ((SQLULEN)Value != 0) {
+				WARNH(dbc, "requested max_rows substituted with 0.");
+				RET_HDIAGS(dbc, SQL_STATE_01S02);
+			}
+			break;
+
 		default:
 			ERRH(dbc, "unknown Attribute: %d.", Attribute);
-			// FIXME: add the other attributes
-			FIXME;
 			RET_HDIAGS(dbc, SQL_STATE_HY092);
 	}