Convert BaseNode(s) Request/Response classes to Writeable (#44301)

This commit converts all BaseNodeResponse and BaseNodesResponse
subclasses to implement Writeable.Reader instead of Streamable.

relates #34389

Author: rjernst

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/NodeHotThreads.java

@@ -30,7 +30,9 @@ public class NodeHotThreads extends BaseNodeResponse {
 
     private String hotThreads;
 
-    NodeHotThreads() {
+    NodeHotThreads(StreamInput in) throws IOException {
+        super(in);
+        hotThreads = in.readString();
     }
 
     public NodeHotThreads(DiscoveryNode node, String hotThreads) {
@@ -42,18 +44,6 @@ public String getHotThreads() {
         return this.hotThreads;
     }
 
-    public static NodeHotThreads readNodeHotThreads(StreamInput in) throws IOException {
-        NodeHotThreads node = new NodeHotThreads();
-        node.readFrom(in);
-        return node;
-    }
-
-    @Override
-    public void readFrom(StreamInput in) throws IOException {
-        super.readFrom(in);
-        hotThreads = in.readString();
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/NodesHotThreadsAction.java

@@ -19,19 +19,14 @@
 
 package org.elasticsearch.action.admin.cluster.node.hotthreads;
 
-import org.elasticsearch.action.StreamableResponseActionType;
+import org.elasticsearch.action.ActionType;
 
-public class NodesHotThreadsAction extends StreamableResponseActionType<NodesHotThreadsResponse> {
+public class NodesHotThreadsAction extends ActionType<NodesHotThreadsResponse> {
 
     public static final NodesHotThreadsAction INSTANCE = new NodesHotThreadsAction();
     public static final String NAME = "cluster:monitor/nodes/hot_threads";
 
     private NodesHotThreadsAction() {
-        super(NAME);
-    }
-
-    @Override
-    public NodesHotThreadsResponse newResponse() {
-        return new NodesHotThreadsResponse();
+        super(NAME, NodesHotThreadsResponse::new);
     }
 }

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/NodesHotThreadsRequest.java

@@ -36,8 +36,13 @@ public class NodesHotThreadsRequest extends BaseNodesRequest<NodesHotThreadsRequ
     boolean ignoreIdleThreads = true;
 
     // for serialization
-    public NodesHotThreadsRequest() {
-
+    public NodesHotThreadsRequest(StreamInput in) throws IOException {
+        super(in);
+        threads = in.readInt();
+        ignoreIdleThreads = in.readBoolean();
+        type = in.readString();
+        interval = in.readTimeValue();
+        snapshots = in.readInt();
     }
 
     /**
@@ -93,16 +98,6 @@ public NodesHotThreadsRequest snapshots(int snapshots) {
         return this;
     }
 
-    @Override
-    public void readFrom(StreamInput in) throws IOException {
-        super.readFrom(in);
-        threads = in.readInt();
-        ignoreIdleThreads = in.readBoolean();
-        type = in.readString();
-        interval = in.readTimeValue();
-        snapshots = in.readInt();
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/NodesHotThreadsResponse.java

@@ -30,7 +30,8 @@
 
 public class NodesHotThreadsResponse extends BaseNodesResponse<NodeHotThreads> {
 
-    NodesHotThreadsResponse() {
+    public NodesHotThreadsResponse(StreamInput in) throws IOException {
+        super(in);
     }
 
     public NodesHotThreadsResponse(ClusterName clusterName, List<NodeHotThreads> nodes, List<FailedNodeException> failures) {
@@ -39,7 +40,7 @@ public NodesHotThreadsResponse(ClusterName clusterName, List<NodeHotThreads> nod
 
     @Override
     protected List<NodeHotThreads> readNodesFrom(StreamInput in) throws IOException {
-        return in.readList(NodeHotThreads::readNodeHotThreads);
+        return in.readList(NodeHotThreads::new);
     }
 
     @Override

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/TransportNodesHotThreadsAction.java

@@ -60,8 +60,8 @@ protected NodeRequest newNodeRequest(NodesHotThreadsRequest request) {
     }
 
     @Override
-    protected NodeHotThreads newNodeResponse() {
-        return new NodeHotThreads();
+    protected NodeHotThreads newNodeResponse(StreamInput in) throws IOException {
+        return new NodeHotThreads(in);
     }
 
     @Override
@@ -83,20 +83,15 @@ public static class NodeRequest extends BaseNodeRequest {
 
         NodesHotThreadsRequest request;
 
-        public NodeRequest() {
+        public NodeRequest(StreamInput in) throws IOException {
+            super(in);
+            request = new NodesHotThreadsRequest(in);
         }
 
         NodeRequest(NodesHotThreadsRequest request) {
             this.request = request;
         }
 
-        @Override
-        public void readFrom(StreamInput in) throws IOException {
-            super.readFrom(in);
-            request = new NodesHotThreadsRequest();
-            request.readFrom(in);
-        }
-
         @Override
         public void writeTo(StreamOutput out) throws IOException {
             super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodeInfo.java

@@ -76,7 +76,26 @@ public class NodeInfo extends BaseNodeResponse {
     @Nullable
     private ByteSizeValue totalIndexingBuffer;
 
-    public NodeInfo() {
+    public NodeInfo(StreamInput in) throws IOException {
+        super(in);
+        version = Version.readVersion(in);
+        build = Build.readBuild(in);
+        if (in.readBoolean()) {
+            totalIndexingBuffer = new ByteSizeValue(in.readLong());
+        } else {
+            totalIndexingBuffer = null;
+        }
+        if (in.readBoolean()) {
+            settings = Settings.readSettingsFromStream(in);
+        }
+        os = in.readOptionalWriteable(OsInfo::new);
+        process = in.readOptionalWriteable(ProcessInfo::new);
+        jvm = in.readOptionalWriteable(JvmInfo::new);
+        threadPool = in.readOptionalWriteable(ThreadPoolInfo::new);
+        transport = in.readOptionalWriteable(TransportInfo::new);
+        http = in.readOptionalWriteable(HttpInfo::new);
+        plugins = in.readOptionalWriteable(PluginsAndModules::new);
+        ingest = in.readOptionalWriteable(IngestInfo::new);
     }
 
     public NodeInfo(Version version, Build build, DiscoveryNode node, @Nullable Settings settings,
@@ -182,35 +201,6 @@ public ByteSizeValue getTotalIndexingBuffer() {
         return totalIndexingBuffer;
     }
 
-    public static NodeInfo readNodeInfo(StreamInput in) throws IOException {
-        NodeInfo nodeInfo = new NodeInfo();
-        nodeInfo.readFrom(in);
-        return nodeInfo;
-    }
-
-    @Override
-    public void readFrom(StreamInput in) throws IOException {
-        super.readFrom(in);
-        version = Version.readVersion(in);
-        build = Build.readBuild(in);
-        if (in.readBoolean()) {
-            totalIndexingBuffer = new ByteSizeValue(in.readLong());
-        } else {
-            totalIndexingBuffer = null;
-        }
-        if (in.readBoolean()) {
-            settings = Settings.readSettingsFromStream(in);
-        }
-        os = in.readOptionalWriteable(OsInfo::new);
-        process = in.readOptionalWriteable(ProcessInfo::new);
-        jvm = in.readOptionalWriteable(JvmInfo::new);
-        threadPool = in.readOptionalWriteable(ThreadPoolInfo::new);
-        transport = in.readOptionalWriteable(TransportInfo::new);
-        http = in.readOptionalWriteable(HttpInfo::new);
-        plugins = in.readOptionalWriteable(PluginsAndModules::new);
-        ingest = in.readOptionalWriteable(IngestInfo::new);
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoAction.java

@@ -19,19 +19,14 @@
 
 package org.elasticsearch.action.admin.cluster.node.info;
 
-import org.elasticsearch.action.StreamableResponseActionType;
+import org.elasticsearch.action.ActionType;
 
-public class NodesInfoAction extends StreamableResponseActionType<NodesInfoResponse> {
+public class NodesInfoAction extends ActionType<NodesInfoResponse> {
 
     public static final NodesInfoAction INSTANCE = new NodesInfoAction();
     public static final String NAME = "cluster:monitor/nodes/info";
 
     private NodesInfoAction() {
-        super(NAME);
-    }
-
-    @Override
-    public NodesInfoResponse newResponse() {
-        return new NodesInfoResponse();
+        super(NAME, NodesInfoResponse::new);
     }
 }

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoRequest.java

@@ -41,7 +41,18 @@ public class NodesInfoRequest extends BaseNodesRequest<NodesInfoRequest> {
     private boolean ingest = true;
     private boolean indices = true;
 
-    public NodesInfoRequest() {
+    public NodesInfoRequest(StreamInput in) throws IOException {
+        super(in);
+        settings = in.readBoolean();
+        os = in.readBoolean();
+        process = in.readBoolean();
+        jvm = in.readBoolean();
+        threadPool = in.readBoolean();
+        transport = in.readBoolean();
+        http = in.readBoolean();
+        plugins = in.readBoolean();
+        ingest = in.readBoolean();
+        indices = in.readBoolean();
     }
 
     /**
@@ -240,21 +251,6 @@ public boolean indices() {
         return indices;
     }
 
-    @Override
-    public void readFrom(StreamInput in) throws IOException {
-        super.readFrom(in);
-        settings = in.readBoolean();
-        os = in.readBoolean();
-        process = in.readBoolean();
-        jvm = in.readBoolean();
-        threadPool = in.readBoolean();
-        transport = in.readBoolean();
-        http = in.readBoolean();
-        plugins = in.readBoolean();
-        ingest = in.readBoolean();
-        indices = in.readBoolean();
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoResponse.java

@@ -37,7 +37,8 @@
 
 public class NodesInfoResponse extends BaseNodesResponse<NodeInfo> implements ToXContentFragment {
 
-    public NodesInfoResponse() {
+    public NodesInfoResponse(StreamInput in) throws IOException {
+        super(in);
     }
 
     public NodesInfoResponse(ClusterName clusterName, List<NodeInfo> nodes, List<FailedNodeException> failures) {
@@ -46,7 +47,7 @@ public NodesInfoResponse(ClusterName clusterName, List<NodeInfo> nodes, List<Fai
 
     @Override
     protected List<NodeInfo> readNodesFrom(StreamInput in) throws IOException {
-        return in.readList(NodeInfo::readNodeInfo);
+        return in.readList(NodeInfo::new);
     }
 
     @Override

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/TransportNodesInfoAction.java

@@ -62,8 +62,8 @@ protected NodeInfoRequest newNodeRequest(NodesInfoRequest request) {
     }
 
     @Override
-    protected NodeInfo newNodeResponse() {
-        return new NodeInfo();
+    protected NodeInfo newNodeResponse(StreamInput in) throws IOException {
+        return new NodeInfo(in);
     }
 
     @Override
@@ -77,20 +77,15 @@ public static class NodeInfoRequest extends BaseNodeRequest {
 
         NodesInfoRequest request;
 
-        public NodeInfoRequest() {
+        public NodeInfoRequest(StreamInput in) throws IOException {
+            super(in);
+            request = new NodesInfoRequest(in);
         }
 
         public NodeInfoRequest(NodesInfoRequest request) {
             this.request = request;
         }
 
-        @Override
-        public void readFrom(StreamInput in) throws IOException {
-            super.readFrom(in);
-            request = new NodesInfoRequest();
-            request.readFrom(in);
-        }
-
         @Override
         public void writeTo(StreamOutput out) throws IOException {
             super.writeTo(out);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/reload/NodesReloadSecureSettingsAction.java

@@ -19,21 +19,14 @@
 
 package org.elasticsearch.action.admin.cluster.node.reload;
 
-import org.elasticsearch.action.StreamableResponseActionType;
+import org.elasticsearch.action.ActionType;
 
-public class NodesReloadSecureSettingsAction
-        extends StreamableResponseActionType<NodesReloadSecureSettingsResponse> {
+public class NodesReloadSecureSettingsAction extends ActionType<NodesReloadSecureSettingsResponse> {
 
     public static final NodesReloadSecureSettingsAction INSTANCE = new NodesReloadSecureSettingsAction();
     public static final String NAME = "cluster:admin/nodes/reload_secure_settings";
 
     private NodesReloadSecureSettingsAction() {
-        super(NAME);
+        super(NAME, NodesReloadSecureSettingsResponse::new);
     }
-
-    @Override
-    public NodesReloadSecureSettingsResponse newResponse() {
-        return new NodesReloadSecureSettingsResponse();
-    }
-
 }

server/src/main/java/org/elasticsearch/action/admin/cluster/node/reload/NodesReloadSecureSettingsRequest.java

@@ -20,13 +20,21 @@
 package org.elasticsearch.action.admin.cluster.node.reload;
 
 import org.elasticsearch.action.support.nodes.BaseNodesRequest;
+import org.elasticsearch.common.io.stream.StreamInput;
+
+import java.io.IOException;
 
 /**
  * Request for a reload secure settings action.
  */
 public class NodesReloadSecureSettingsRequest extends BaseNodesRequest<NodesReloadSecureSettingsRequest> {
 
     public NodesReloadSecureSettingsRequest() {
+        super((String[]) null);
+    }
+
+    public NodesReloadSecureSettingsRequest(StreamInput in) throws IOException {
+        super(in);
     }
 
     /**