Skip to content

Commit 14aca62

Browse files
committed
remove size tests
1 parent c9a4901 commit 14aca62

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

core/src/main/java/org/elasticsearch/index/translog/MultiSnapshot.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
package org.elasticsearch.index.translog;
2121

2222
import com.carrotsearch.hppc.LongObjectHashMap;
23-
import com.carrotsearch.hppc.cursors.ObjectCursor;
2423
import org.apache.lucene.util.BitSet;
2524
import org.elasticsearch.common.util.CountedBitSet;
2625
import org.elasticsearch.index.seqno.SequenceNumbers;
@@ -104,21 +103,5 @@ boolean getAndSet(long value) {
104103
bitset.set(index);
105104
return wasOn;
106105
}
107-
108-
// For testing
109-
long completeSetsSize() {
110-
int completedBitSets = 0;
111-
for (ObjectCursor<BitSet> bitset : bitSets.values()) {
112-
if (bitset.value.cardinality() == bitset.value.length()) {
113-
completedBitSets++;
114-
}
115-
}
116-
return completedBitSets;
117-
}
118-
119-
// For testing
120-
long ongoingSetsSize() {
121-
return bitSets.size() - completeSetsSize();
122-
}
123106
}
124107
}

core/src/test/java/org/elasticsearch/index/translog/MultiSnapshotTests.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import java.util.stream.LongStream;
3131

3232
import static org.hamcrest.CoreMatchers.equalTo;
33-
import static org.hamcrest.Matchers.lessThanOrEqualTo;
3433

3534
public class MultiSnapshotTests extends ESTestCase {
3635

@@ -40,14 +39,8 @@ public void testTrackSeqNoSimpleRange() throws Exception {
4039
Randomness.shuffle(values);
4140
for (int i = 0; i < 1023; i++) {
4241
assertThat(bitSet.getAndSet(values.get(i)), equalTo(false));
43-
assertThat(bitSet.ongoingSetsSize(), equalTo(1L));
44-
assertThat(bitSet.completeSetsSize(), equalTo(0L));
4542
}
46-
4743
assertThat(bitSet.getAndSet(values.get(1023)), equalTo(false));
48-
assertThat(bitSet.ongoingSetsSize(), equalTo(0L));
49-
assertThat(bitSet.completeSetsSize(), equalTo(1L));
50-
5144
assertThat(bitSet.getAndSet(between(0, 1023)), equalTo(true));
5245
assertThat(bitSet.getAndSet(between(1024, Integer.MAX_VALUE)), equalTo(false));
5346
}
@@ -59,7 +52,6 @@ public void testTrackSeqNoDenseRanges() throws Exception {
5952
long seq = between(0, 5000);
6053
boolean existed = normalSet.add(seq) == false;
6154
assertThat("SeqNoSet != Set" + seq, bitSet.getAndSet(seq), equalTo(existed));
62-
assertThat(bitSet.ongoingSetsSize() + bitSet.completeSetsSize(), lessThanOrEqualTo(5L));
6355
});
6456
}
6557

@@ -78,12 +70,8 @@ public void testTrackSeqNoMimicTranslogRanges() throws Exception {
7870
final LongSet normalSet = new LongHashSet();
7971
long currentSeq = between(10_000_000, 1_000_000_000);
8072
final int iterations = scaledRandomIntBetween(100, 2000);
81-
assertThat(bitSet.completeSetsSize(), equalTo(0L));
82-
assertThat(bitSet.ongoingSetsSize(), equalTo(0L));
83-
long totalDocs = 0;
8473
for (long i = 0; i < iterations; i++) {
8574
int batchSize = between(1, 1500);
86-
totalDocs += batchSize;
8775
currentSeq -= batchSize;
8876
List<Long> batch = LongStream.range(currentSeq, currentSeq + batchSize)
8977
.boxed()
@@ -92,11 +80,7 @@ public void testTrackSeqNoMimicTranslogRanges() throws Exception {
9280
batch.forEach(seq -> {
9381
boolean existed = normalSet.add(seq) == false;
9482
assertThat("SeqNoSet != Set", bitSet.getAndSet(seq), equalTo(existed));
95-
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(4L));
9683
});
97-
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(2L));
9884
}
99-
assertThat(bitSet.completeSetsSize(), lessThanOrEqualTo(totalDocs / 1024));
100-
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(2L));
10185
}
10286
}

0 commit comments

Comments
 (0)