Skip to content

Commit 1dbd239

Browse files
Kenta Suzukidadoonet
Kenta Suzuki
authored andcommitted
Elasticsearch dependency should be provided and not compile
Please change the Elasticsearch dependency to provided (and maybe testCompile) instead of compile and runtime. Why? If you include the plugin in embedded Elasticsearch, and you exclude anything from the Elasticsearch dependency, it is undone by this dependency also including Elasticsearch. Therefore you have to tune both, when really this plugin only needs it as provided (since it runs with Elasticsearch or in Elasticsearch but never on its own). Related to #48.
1 parent c117c11 commit 1dbd239

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pom.xml

+6
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@
7272
<version>${elasticsearch.version}</version>
7373
<scope>provided</scope>
7474
</dependency>
75+
<dependency>
76+
<groupId>org.apache.lucene</groupId>
77+
<artifactId>lucene-core</artifactId>
78+
<version>${lucene.version}</version>
79+
<scope>provided</scope>
80+
</dependency>
7581

7682
<dependency>
7783
<groupId>org.elasticsearch</groupId>

0 commit comments

Comments
 (0)