Skip to content

Commit 2061652

Browse files
authored
Ensure auto close of HTMLStripCharFilter in HtmlStripProcessor
The HtmlStripProcessor did not use a try-with resources block to ensure that the used HTMLStripCharFilter is closed.
1 parent d53c941 commit 2061652

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/HtmlStripProcessor.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,11 @@ protected String process(String value) {
4141
return value;
4242
}
4343

44-
HTMLStripCharFilter filter = new HTMLStripCharFilter(new StringReader(value));
45-
4644
StringBuilder builder = new StringBuilder();
47-
int ch;
48-
try {
45+
try (HTMLStripCharFilter filter = new HTMLStripCharFilter(new StringReader(value))) {
46+
int ch;
4947
while ((ch = filter.read()) != -1) {
50-
builder.append((char)ch);
48+
builder.append((char) ch);
5149
}
5250
} catch (IOException e) {
5351
throw new ElasticsearchException(e);

0 commit comments

Comments
 (0)