EngineTestCase#getDocIds should use internal reader (#49564)

dnhatn · web-flow · commit 206540a42746 · 2019-11-25T20:10:52.000-05:00
We do not guarantee that EngineTestCase#getDocIds is called after the engine has been externally refreshed. Hence, we trip an assertion assertSearcherIsWarmedUp. CI: https://gradle-enterprise.elastic.co/s/pm2at5qmfm2iu Relates #48605
diff --git a/test/framework/src/main/java/org/elasticsearch/index/engine/EngineTestCase.java b/test/framework/src/main/java/org/elasticsearch/index/engine/EngineTestCase.java
@@ -1010,7 +1010,7 @@ public static List<DocIdSeqNoAndSource> getDocIds(Engine engine, boolean refresh
         if (refresh) {
             engine.refresh("test_get_doc_ids");
         }
-        try (Engine.Searcher searcher = engine.acquireSearcher("test_get_doc_ids")) {
+        try (Engine.Searcher searcher = engine.acquireSearcher("test_get_doc_ids", Engine.SearcherScope.INTERNAL)) {
             List<DocIdSeqNoAndSource> docs = new ArrayList<>();
             for (LeafReaderContext leafContext : searcher.getIndexReader().leaves()) {
                 LeafReader reader = leafContext.reader();

Original file line number	Diff line number	Diff line change
`@@ -1010,7 +1010,7 @@ public static List<DocIdSeqNoAndSource> getDocIds(Engine engine, boolean refresh`
`1010`	`1010`	`if (refresh) {`
`1011`	`1011`	`engine.refresh("test_get_doc_ids");`
`1012`	`1012`	`}`
`1013`		`- try (Engine.Searcher searcher = engine.acquireSearcher("test_get_doc_ids")) {`
	`1013`	`+ try (Engine.Searcher searcher = engine.acquireSearcher("test_get_doc_ids", Engine.SearcherScope.INTERNAL)) {`
`1014`	`1014`	`List<DocIdSeqNoAndSource> docs = new ArrayList<>();`
`1015`	`1015`	`for (LeafReaderContext leafContext : searcher.getIndexReader().leaves()) {`
`1016`	`1016`	`LeafReader reader = leafContext.reader();`