Skip to content

Commit 21224ca

Browse files
rjernstrjernst
committed
Remove comparison to true for booleans (#51723)
While we use `== false` as a more visible form of boolean negation (instead of `!`), the true case is implied and the true value does not need to explicitly checked. This commit converts cases that have slipped into the code checking for `== true`.
1 parent 61622c4 commit 21224ca

File tree

54 files changed

+88
-91
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+88
-91
lines changed

‎buildSrc/src/main/groovy/org/elasticsearch/gradle/test/AntFixture.groovy

-2
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ import org.elasticsearch.gradle.LoggedExec
2525
import org.gradle.api.GradleException
2626
import org.gradle.api.Task
2727
import org.gradle.api.tasks.Exec
28-
import org.gradle.api.tasks.Input
2928
import org.gradle.api.tasks.Internal
30-
3129
/**
3230
* A fixture for integration tests which runs in a separate process launched by Ant.
3331
*/

‎buildSrc/src/main/java/org/elasticsearch/gradle/test/DistroTestPlugin.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public void apply(Project project) {
108108

109109
TaskProvider<Task> destructiveDistroTest = project.getTasks().register("destructiveDistroTest");
110110
for (ElasticsearchDistribution distribution : distributions) {
111-
if (distribution.getType() != Type.DOCKER || runDockerTests == true) {
111+
if (distribution.getType() != Type.DOCKER || runDockerTests) {
112112
TaskProvider<?> destructiveTask = configureDistroTest(project, distribution);
113113
destructiveDistroTest.configure(t -> t.dependsOn(destructiveTask));
114114
}
@@ -152,7 +152,7 @@ public void apply(Project project) {
152152
//
153153
// The shouldTestDocker property could be null, hence we use Boolean.TRUE.equals()
154154
boolean shouldExecute = distribution.getType() != Type.DOCKER
155-
|| Boolean.TRUE.equals(vmProject.findProperty("shouldTestDocker")) == true;
155+
|| Boolean.TRUE.equals(vmProject.findProperty("shouldTestDocker"));
156156

157157
if (shouldExecute) {
158158
t.dependsOn(vmTask);

‎buildSrc/src/main/java/org/elasticsearch/gradle/tool/DockerUtils.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,19 @@ private static DockerAvailability getDockerAvailability(Project project) {
5353
// Since we use a multi-stage Docker build, check the Docker version since 17.05
5454
lastResult = runCommand(project, dockerPath, "version", "--format", "{{.Server.Version}}");
5555

56-
if (lastResult.isSuccess() == true) {
56+
if (lastResult.isSuccess()) {
5757
version = Version.fromString(lastResult.stdout.trim(), Version.Mode.RELAXED);
5858

5959
isVersionHighEnough = version.onOrAfter("17.05.0");
6060

61-
if (isVersionHighEnough == true) {
61+
if (isVersionHighEnough) {
6262
// Check that we can execute a privileged command
6363
lastResult = runCommand(project, dockerPath, "images");
6464
}
6565
}
6666
}
6767

68-
boolean isAvailable = isVersionHighEnough && lastResult.isSuccess() == true;
68+
boolean isAvailable = isVersionHighEnough && lastResult.isSuccess();
6969

7070
return new DockerAvailability(isAvailable, isVersionHighEnough, dockerPath, version, lastResult);
7171
}
@@ -125,7 +125,7 @@ private static class DockerAvailability {
125125
public static void assertDockerIsAvailable(Project project, List<String> tasks) {
126126
DockerAvailability availability = getDockerAvailability(project);
127127

128-
if (availability.isAvailable == true) {
128+
if (availability.isAvailable) {
129129
return;
130130
}
131131

‎buildSrc/src/minimumRuntime/java/org/elasticsearch/gradle/Version.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static Version fromString(final String s, final Mode mode) {
6060
Objects.requireNonNull(s);
6161
Matcher matcher = mode == Mode.STRICT ? pattern.matcher(s) : relaxedPattern.matcher(s);
6262
if (matcher.matches() == false) {
63-
String expected = mode == Mode.STRICT == true
63+
String expected = mode == Mode.STRICT
6464
? "major.minor.revision[-(alpha|beta|rc)Number][-SNAPSHOT]"
6565
: "major.minor.revision[-extra]";
6666
throw new IllegalArgumentException("Invalid version format: '" + s + "'. Should be " + expected);

‎client/rest-high-level/src/test/java/org/elasticsearch/client/core/TermVectorsResponseTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ static TermVectorsResponse createTestInstance() {
125125
long tookInMillis = randomNonNegativeLong();
126126
boolean found = randomBoolean();
127127
List<TermVectorsResponse.TermVector> tvList = null;
128-
if (found == true){
128+
if (found){
129129
boolean hasFieldStatistics = randomBoolean();
130130
boolean hasTermStatistics = randomBoolean();
131131
boolean hasScores = randomBoolean();

‎libs/geo/src/main/java/org/elasticsearch/geometry/utils/WellKnownText.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ private Circle parseCircle(StreamTokenizer stream) throws IOException, ParseExce
482482
double lat = nextNumber(stream);
483483
double radius = nextNumber(stream);
484484
double alt = Double.NaN;
485-
if (isNumberNext(stream) == true) {
485+
if (isNumberNext(stream)) {
486486
alt = nextNumber(stream);
487487
}
488488
Circle circle = new Circle(lon, lat, alt, radius);
@@ -560,7 +560,7 @@ private String nextCloser(StreamTokenizer stream) throws IOException, ParseExcep
560560
}
561561

562562
private String nextComma(StreamTokenizer stream) throws IOException, ParseException {
563-
if (nextWord(stream).equals(COMMA) == true) {
563+
if (nextWord(stream).equals(COMMA)) {
564564
return COMMA;
565565
}
566566
throw new ParseException("expected " + COMMA + " but found: " + tokenString(stream), stream.lineno());

‎libs/grok/src/main/java/org/elasticsearch/grok/MatcherWatchdog.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ private Default(long interval,
128128
public void register(Matcher matcher) {
129129
registered.getAndIncrement();
130130
Long previousValue = registry.put(matcher, relativeTimeSupplier.getAsLong());
131-
if (running.compareAndSet(false, true) == true) {
131+
if (running.compareAndSet(false, true)) {
132132
scheduler.accept(interval, this::interruptLongRunningExecutions);
133133
}
134134
assert previousValue == null;

‎modules/aggs-matrix-stats/src/main/java/org/elasticsearch/search/aggregations/matrix/stats/MatrixStatsAggregator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public LeafBucketCollector getLeafCollector(LeafReaderContext ctx,
8585
@Override
8686
public void collect(int doc, long bucket) throws IOException {
8787
// get fields
88-
if (includeDocument(doc) == true) {
88+
if (includeDocument(doc)) {
8989
stats = bigArrays.grow(stats, bucket + 1);
9090
RunningStats stat = stats.get(bucket);
9191
// add document fields to correlation stats

‎modules/aggs-matrix-stats/src/main/java/org/elasticsearch/search/aggregations/matrix/stats/RunningStats.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public void add(final String[] fieldNames, final double[] fieldVals) {
155155
deltas.put(fieldName, fieldValue * docCount - fieldSum.get(fieldName));
156156

157157
// update running mean, variance, skewness, kurtosis
158-
if (means.containsKey(fieldName) == true) {
158+
if (means.containsKey(fieldName)) {
159159
// update running means
160160
m1 = means.get(fieldName);
161161
d = fieldValue - m1;
@@ -194,7 +194,7 @@ private void updateCovariance(final String[] fieldNames, final Map<String, Doubl
194194
dR = deltas.get(fieldName);
195195
HashMap<String, Double> cFieldVals = (covariances.get(fieldName) != null) ? covariances.get(fieldName) : new HashMap<>();
196196
for (String cFieldName : cFieldNames) {
197-
if (cFieldVals.containsKey(cFieldName) == true) {
197+
if (cFieldVals.containsKey(cFieldName)) {
198198
newVal = cFieldVals.get(cFieldName) + 1.0 / (docCount * (docCount - 1.0)) * dR * deltas.get(cFieldName);
199199
cFieldVals.put(cFieldName, newVal);
200200
} else {
@@ -224,7 +224,7 @@ public void merge(final RunningStats other) {
224224
this.variances.put(fieldName, other.variances.get(fieldName).doubleValue());
225225
this.skewness.put(fieldName , other.skewness.get(fieldName).doubleValue());
226226
this.kurtosis.put(fieldName, other.kurtosis.get(fieldName).doubleValue());
227-
if (other.covariances.containsKey(fieldName) == true) {
227+
if (other.covariances.containsKey(fieldName)) {
228228
this.covariances.put(fieldName, other.covariances.get(fieldName));
229229
}
230230
this.docCount = other.docCount;

‎modules/lang-painless/src/main/java/org/elasticsearch/painless/lookup/PainlessLookupBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ public void addPainlessClass(Class<?> clazz, boolean importClassName) {
293293
String importedCanonicalClassName = javaClassName.substring(javaClassName.lastIndexOf('.') + 1).replace('$', '.');
294294

295295
if (canonicalClassName.equals(importedCanonicalClassName)) {
296-
if (importClassName == true) {
296+
if (importClassName) {
297297
throw new IllegalArgumentException("must use no_import parameter on class [" + canonicalClassName + "] with no package");
298298
}
299299
} else {

‎modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RatedSearchHit.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public RatedSearchHit(SearchHit searchHit, OptionalInt rating) {
4949
}
5050

5151
RatedSearchHit(StreamInput in) throws IOException {
52-
this(new SearchHit(in), in.readBoolean() == true ? OptionalInt.of(in.readVInt()) : OptionalInt.empty());
52+
this(new SearchHit(in), in.readBoolean() ? OptionalInt.of(in.readVInt()) : OptionalInt.empty());
5353
}
5454

5555
@Override

‎qa/os/src/test/java/org/elasticsearch/packaging/test/PackagingTestCase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public void assertElasticsearchFailure(Shell.Result result, String expectedMessa
328328
Shell.Result error = journaldWrapper.getLogs();
329329
assertThat(error.stdout, containsString(expectedMessage));
330330

331-
} else if (Platforms.WINDOWS == true) {
331+
} else if (Platforms.WINDOWS) {
332332

333333
// In Windows, we have written our stdout and stderr to files in order to run
334334
// in the background

‎server/src/main/java/org/elasticsearch/common/Rounding.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static class TimeUnitRounding extends Rounding {
260260
this.unit = unit;
261261
this.timeZone = timeZone;
262262
this.unitRoundsToMidnight = this.unit.field.getBaseUnit().getDuration().toMillis() > 3600000L;
263-
this.fixedOffsetMillis = timeZone.getRules().isFixedOffset() == true ?
263+
this.fixedOffsetMillis = timeZone.getRules().isFixedOffset() ?
264264
timeZone.getRules().getOffset(Instant.EPOCH).getTotalSeconds() * 1000 : TZ_OFFSET_NON_FIXED;
265265
}
266266

@@ -486,7 +486,7 @@ static class TimeIntervalRounding extends Rounding {
486486
throw new IllegalArgumentException("Zero or negative time interval not supported");
487487
this.interval = interval;
488488
this.timeZone = timeZone;
489-
this.fixedOffsetMillis = timeZone.getRules().isFixedOffset() == true ?
489+
this.fixedOffsetMillis = timeZone.getRules().isFixedOffset() ?
490490
timeZone.getRules().getOffset(Instant.EPOCH).getTotalSeconds() * 1000 : TZ_OFFSET_NON_FIXED;
491491
}
492492

‎server/src/main/java/org/elasticsearch/common/geo/GeoShapeType.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ void validateLinearRing(CoordinateNode coordinates, boolean coerce) {
170170
// close linear ring iff coerce is set and ring is open, otherwise throw parse exception
171171
if (!coordinates.children.get(0).coordinate.equals(
172172
coordinates.children.get(coordinates.children.size() - 1).coordinate)) {
173-
if (coerce == true) {
173+
if (coerce) {
174174
coordinates.children.add(coordinates.children.get(0));
175175
} else {
176176
throw new ElasticsearchParseException("invalid LinearRing found (coordinates are not closed)");

‎server/src/main/java/org/elasticsearch/common/geo/parsers/GeoWKTParser.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ private static PointBuilder parsePoint(StreamTokenizer stream, final boolean ign
152152
return null;
153153
}
154154
PointBuilder pt = new PointBuilder(nextNumber(stream), nextNumber(stream));
155-
if (isNumberNext(stream) == true) {
155+
if (isNumberNext(stream)) {
156156
GeoPoint.assertZValue(ignoreZValue, nextNumber(stream));
157157
}
158158
nextCloser(stream);
@@ -224,7 +224,7 @@ private static LineStringBuilder parseLinearRing(StreamTokenizer stream, final b
224224
int coordinatesNeeded = coerce ? 3 : 4;
225225
if (coordinates.size() >= coordinatesNeeded) {
226226
if (!coordinates.get(0).equals(coordinates.get(coordinates.size() - 1))) {
227-
if (coerce == true) {
227+
if (coerce) {
228228
coordinates.add(coordinates.get(0));
229229
} else {
230230
throw new ElasticsearchParseException("invalid LinearRing found (coordinates are not closed)");
@@ -352,7 +352,7 @@ private static String nextCloser(StreamTokenizer stream) throws IOException, Ela
352352
}
353353

354354
private static String nextComma(StreamTokenizer stream) throws IOException, ElasticsearchParseException {
355-
if (nextWord(stream).equals(COMMA) == true) {
355+
if (nextWord(stream).equals(COMMA)) {
356356
return COMMA;
357357
}
358358
throw new ElasticsearchParseException("expected " + COMMA + " but found: " + tokenString(stream), stream.lineno());

‎server/src/main/java/org/elasticsearch/common/time/JavaDateFormatter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ private TemporalAccessor doParse(String input) {
189189
for (DateTimeFormatter formatter : parsers) {
190190
ParsePosition pos = new ParsePosition(0);
191191
Object object = formatter.toFormat().parseObject(input, pos);
192-
if (parsingSucceeded(object, input, pos) == true) {
192+
if (parsingSucceeded(object, input, pos)) {
193193
return (TemporalAccessor) object;
194194
}
195195
}

‎server/src/main/java/org/elasticsearch/index/mapper/LegacyGeoShapeIndexer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public Class<Shape> processedClass() {
5151

5252
@Override
5353
public List<IndexableField> indexShape(ParseContext context, Shape shape) {
54-
if (fieldType.pointsOnly() == true) {
54+
if (fieldType.pointsOnly()) {
5555
// index configured for pointsOnly
5656
if (shape instanceof XShapeCollection && XShapeCollection.class.cast(shape).pointsOnly()) {
5757
// MULTIPOINT data: index each point separately

‎server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public RangeFieldType fieldType() {
9494

9595
@Override
9696
public Builder docValues(boolean docValues) {
97-
if (docValues == true) {
97+
if (docValues) {
9898
throw new IllegalArgumentException("field [" + name + "] does not currently support " + TypeParsers.DOC_VALUES);
9999
}
100100
return super.docValues(docValues);

‎server/src/main/java/org/elasticsearch/index/query/InnerHitBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ public InnerHitBuilder setDocValueFields(List<FieldAndFormat> docValueFields) {
365365
* Adds a field to load from the docvalue and return.
366366
*/
367367
public InnerHitBuilder addDocValueField(String field, String format) {
368-
if (docValueFields == null || docValueFields.isEmpty() == true) {
368+
if (docValueFields == null || docValueFields.isEmpty()) {
369369
docValueFields = new ArrayList<>();
370370
}
371371
docValueFields.add(new FieldAndFormat(field, format));

‎server/src/main/java/org/elasticsearch/indices/recovery/MultiFileWriter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ void writeChunk(FileChunk newChunk) throws IOException {
215215
assert lastPosition == chunk.position : "last_position " + lastPosition + " != chunk_position " + chunk.position;
216216
lastPosition += chunk.content.length();
217217
if (chunk.lastChunk) {
218-
assert pendingChunks.isEmpty() == true : "still have pending chunks [" + pendingChunks + "]";
218+
assert pendingChunks.isEmpty() : "still have pending chunks [" + pendingChunks + "]";
219219
fileChunkWriters.remove(chunk.md.name());
220220
assert fileChunkWriters.containsValue(this) == false : "chunk writer [" + newChunk.md + "] was not removed";
221221
}

‎server/src/main/java/org/elasticsearch/search/profile/aggregation/InternalAggregationProfileTree.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ protected String getTypeFromElement(Aggregator element) {
3535

3636
// Anonymous classes (such as NonCollectingAggregator in TermsAgg) won't have a name,
3737
// we need to get the super class
38-
if (element.getClass().getSimpleName().isEmpty() == true) {
38+
if (element.getClass().getSimpleName().isEmpty()) {
3939
return element.getClass().getSuperclass().getSimpleName();
4040
}
4141
if (element instanceof MultiBucketAggregatorWrapper) {

‎server/src/main/java/org/elasticsearch/search/profile/query/InternalQueryProfileTree.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected QueryProfileBreakdown createProfileBreakdown() {
4343
protected String getTypeFromElement(Query query) {
4444
// Anonymous classes won't have a name,
4545
// we need to get the super class
46-
if (query.getClass().getSimpleName().isEmpty() == true) {
46+
if (query.getClass().getSimpleName().isEmpty()) {
4747
return query.getClass().getSuperclass().getSimpleName();
4848
}
4949
return query.getClass().getSimpleName();

‎test/framework/src/main/java/org/elasticsearch/common/util/NamedFormatter.java

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public static String format(String fmt, Map<String, Object> values) {
5656
final Matcher matcher = PARAM_REGEX.matcher(fmt);
5757

5858
boolean result = matcher.find();
59-
6059
if (result) {
6160
final StringBuffer sb = new StringBuffer();
6261
do {

‎test/framework/src/main/java/org/elasticsearch/test/InternalTestCluster.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ private synchronized NodeAndClient buildNode(int nodeId, Settings settings,
700700
onTransportServiceStarted.run(); // reusing an existing node implies its transport service already started
701701
return nodeAndClient;
702702
}
703-
assert reuseExisting == true || nodeAndClient == null : "node name [" + name + "] already exists but not allowed to use it";
703+
assert reuseExisting || nodeAndClient == null : "node name [" + name + "] already exists but not allowed to use it";
704704

705705
SecureSettings secureSettings = Settings.builder().put(settings).getSecureSettings();
706706
if (secureSettings instanceof MockSecureSettings) {

‎x-pack/plugin/analytics/src/main/java/org/elasticsearch/xpack/analytics/stringstats/InternalStringStats.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -237,15 +237,15 @@ public XContentBuilder doXContentBody(XContentBuilder builder, Params params) th
237237
builder.field(Fields.MAX_LENGTH.getPreferredName(), maxLength);
238238
builder.field(Fields.AVG_LENGTH.getPreferredName(), getAvgLength());
239239
builder.field(Fields.ENTROPY.getPreferredName(), getEntropy());
240-
if (showDistribution == true) {
240+
if (showDistribution) {
241241
builder.field(Fields.DISTRIBUTION.getPreferredName(), getDistribution());
242242
}
243243
if (format != DocValueFormat.RAW) {
244244
builder.field(Fields.MIN_LENGTH_AS_STRING.getPreferredName(), format.format(getMinLength()));
245245
builder.field(Fields.MAX_LENGTH_AS_STRING.getPreferredName(), format.format(getMaxLength()));
246246
builder.field(Fields.AVG_LENGTH_AS_STRING.getPreferredName(), format.format(getAvgLength()));
247247
builder.field(Fields.ENTROPY_AS_STRING.getPreferredName(), format.format(getEntropy()));
248-
if (showDistribution == true) {
248+
if (showDistribution) {
249249
builder.startObject(Fields.DISTRIBUTION_AS_STRING.getPreferredName());
250250
for (Map.Entry<String, Double> e: getDistribution().entrySet()) {
251251
builder.field(e.getKey(), format.format(e.getValue()).toString());
@@ -259,7 +259,7 @@ public XContentBuilder doXContentBody(XContentBuilder builder, Params params) th
259259
builder.nullField(Fields.AVG_LENGTH.getPreferredName());
260260
builder.field(Fields.ENTROPY.getPreferredName(), 0.0);
261261

262-
if (showDistribution == true) {
262+
if (showDistribution) {
263263
builder.nullField(Fields.DISTRIBUTION.getPreferredName());
264264
}
265265
}

‎x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/datafeed/DatafeedConfig.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
462462
builder.startObject();
463463
builder.field(ID.getPreferredName(), id);
464464
builder.field(Job.ID.getPreferredName(), jobId);
465-
if (params.paramAsBoolean(ToXContentParams.FOR_INTERNAL_STORAGE, false) == true) {
465+
if (params.paramAsBoolean(ToXContentParams.FOR_INTERNAL_STORAGE, false)) {
466466
builder.field(CONFIG_TYPE.getPreferredName(), TYPE);
467467
}
468468
builder.field(QUERY_DELAY.getPreferredName(), queryDelay.getStringRep());
@@ -485,7 +485,7 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
485485
if (chunkingConfig != null) {
486486
builder.field(CHUNKING_CONFIG.getPreferredName(), chunkingConfig);
487487
}
488-
if (headers.isEmpty() == false && params.paramAsBoolean(ToXContentParams.FOR_INTERNAL_STORAGE, false) == true) {
488+
if (headers.isEmpty() == false && params.paramAsBoolean(ToXContentParams.FOR_INTERNAL_STORAGE, false)) {
489489
builder.field(HEADERS.getPreferredName(), headers);
490490
}
491491
if (delayedDataCheckConfig != null) {

‎x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ssl/SSLService.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ private void validateServerConfiguration(String prefix) {
529529
assert prefix.endsWith(".ssl");
530530
SSLConfiguration configuration = getSSLConfiguration(prefix);
531531
final String enabledSetting = prefix + ".enabled";
532-
if (settings.getAsBoolean(enabledSetting, false) == true) {
532+
if (settings.getAsBoolean(enabledSetting, false)) {
533533
// Client Authentication _should_ be required, but if someone turns it off, then this check is no longer relevant
534534
final SSLConfigurationSettings configurationSettings = SSLConfigurationSettings.withPrefix(prefix + ".");
535535
if (isConfigurationValidForServerUsage(configuration) == false) {

0 commit comments

Comments
 (0)