Skip to content

Commit 21c5eeb

Browse files
committed
Fixup tests
1 parent b4823e8 commit 21c5eeb

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

server/src/test/java/org/elasticsearch/search/aggregations/bucket/terms/KeywordTermsAggregatorTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package org.elasticsearch.search.aggregations.bucket.terms;
99

1010
import org.apache.lucene.document.Document;
11+
import org.apache.lucene.document.Field;
1112
import org.apache.lucene.document.SortedSetDocValuesField;
1213
import org.apache.lucene.index.DirectoryReader;
1314
import org.apache.lucene.index.IndexReader;
@@ -87,11 +88,15 @@ public void testMatchAllDocs() throws IOException {
8788
private void testSearchCase(Query query, List<String> dataset,
8889
Consumer<TermsAggregationBuilder> configure,
8990
Consumer<InternalMappedTerms> verify, ValueType valueType) throws IOException {
91+
MappedFieldType keywordFieldType = new KeywordFieldMapper.KeywordFieldType(KEYWORD_FIELD, randomBoolean(), true, null);
9092
try (Directory directory = newDirectory()) {
9193
try (RandomIndexWriter indexWriter = new RandomIndexWriter(random(), directory)) {
9294
Document document = new Document();
9395
for (String value : dataset) {
9496
document.add(new SortedSetDocValuesField(KEYWORD_FIELD, new BytesRef(value)));
97+
if (keywordFieldType.isSearchable()) {
98+
document.add(new Field(KEYWORD_FIELD, new BytesRef(value), KeywordFieldMapper.Defaults.FIELD_TYPE));
99+
}
95100
indexWriter.addDocument(document);
96101
document.clear();
97102
}
@@ -108,7 +113,6 @@ private void testSearchCase(Query query, List<String> dataset,
108113
configure.accept(aggregationBuilder);
109114
}
110115

111-
MappedFieldType keywordFieldType = new KeywordFieldMapper.KeywordFieldType(KEYWORD_FIELD);
112116

113117
InternalMappedTerms rareTerms = searchAndReduce(indexSearcher, query, aggregationBuilder, keywordFieldType);
114118
verify.accept(rareTerms);

x-pack/plugin/analytics/src/test/java/org/elasticsearch/xpack/analytics/normalize/NormalizeAggregatorTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ private void testCase(ValuesSourceAggregationBuilder<?> aggBuilder, Consumer<Int
152152
// setup mapping
153153
DateFieldMapper.DateFieldType dateFieldType = new DateFieldMapper.DateFieldType(DATE_FIELD);
154154
MappedFieldType valueFieldType = new NumberFieldMapper.NumberFieldType(VALUE_FIELD, NumberFieldMapper.NumberType.LONG);
155-
MappedFieldType termFieldType = new KeywordFieldMapper.KeywordFieldType(TERM_FIELD);
155+
MappedFieldType termFieldType = new KeywordFieldMapper.KeywordFieldType(TERM_FIELD, false, true, null);
156156

157157
try (IndexReader indexReader = DirectoryReader.open(directory)) {
158158
IndexSearcher indexSearcher = newIndexSearcher(indexReader);

0 commit comments

Comments
 (0)