Skip to content

Commit 281ae6c

Browse files
author
Hendrik Muhs
authored
[Transform] weighted avg should map to double (#64586)
weighted avg like avg returns always a double value, this changes changes the output mapping from dynamic to double
1 parent f1e9aec commit 281ae6c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ enum AggregationType {
103103
GEO_CENTROID("geo_centroid", GEO_POINT),
104104
GEO_BOUNDS("geo_bounds", GEO_SHAPE),
105105
SCRIPTED_METRIC("scripted_metric", DYNAMIC),
106-
WEIGHTED_AVG("weighted_avg", DYNAMIC),
106+
WEIGHTED_AVG("weighted_avg", DOUBLE),
107107
BUCKET_SELECTOR("bucket_selector", DYNAMIC),
108108
BUCKET_SCRIPT("bucket_script", DYNAMIC),
109109
PERCENTILES("percentiles", DOUBLE),

x-pack/plugin/transform/src/test/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregationsTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@ public void testResolveTargetMapping() {
7878
assertEquals("_dynamic", TransformAggregations.resolveTargetMapping("bucket_selector", "int"));
7979

8080
// weighted_avg
81-
assertEquals("_dynamic", TransformAggregations.resolveTargetMapping("weighted_avg", null));
82-
assertEquals("_dynamic", TransformAggregations.resolveTargetMapping("weighted_avg", "double"));
81+
assertEquals("double", TransformAggregations.resolveTargetMapping("weighted_avg", null));
82+
assertEquals("double", TransformAggregations.resolveTargetMapping("weighted_avg", "double"));
83+
assertEquals("double", TransformAggregations.resolveTargetMapping("weighted_avg", "int"));
8384

8485
// percentile
8586
assertEquals("double", TransformAggregations.resolveTargetMapping("percentiles", null));

0 commit comments

Comments
 (0)