Remove unnecessary fromValue method for ClusterHealthStatus (#53893)

We use readFrom as a standard name for deserializing an object, but
ClusterHealthStatus also had a `fromValue` method which was used during
outer deserialization. This commit collapses the two methods together.

closes #53569

Author: rjernst

server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthRequest.java

@@ -73,7 +73,7 @@ public ClusterHealthRequest(StreamInput in) throws IOException {
         }
         timeout = in.readTimeValue();
         if (in.readBoolean()) {
-            waitForStatus = ClusterHealthStatus.fromValue(in.readByte());
+            waitForStatus = ClusterHealthStatus.readFrom(in);
         }
         waitForNoRelocatingShards = in.readBoolean();
         waitForActiveShards = ActiveShardCount.readFrom(in);

server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthResponse.java

@@ -147,7 +147,7 @@ public ClusterHealthResponse() {}
     public ClusterHealthResponse(StreamInput in) throws IOException {
         super(in);
         clusterName = in.readString();
-        clusterHealthStatus = ClusterHealthStatus.fromValue(in.readByte());
+        clusterHealthStatus = ClusterHealthStatus.readFrom(in);
         clusterStateHealth = new ClusterStateHealth(in);
         numberOfPendingTasks = in.readInt();
         timedOut = in.readBoolean();

server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodeResponse.java

@@ -42,7 +42,7 @@ public ClusterStatsNodeResponse(StreamInput in) throws IOException {
         super(in);
         clusterStatus = null;
         if (in.readBoolean()) {
-            clusterStatus = ClusterHealthStatus.fromValue(in.readByte());
+            clusterStatus = ClusterHealthStatus.readFrom(in);
         }
         this.nodeInfo = new NodeInfo(in);
         this.nodeStats = new NodeStats(in);

server/src/main/java/org/elasticsearch/action/admin/indices/shards/IndicesShardStoresRequest.java

@@ -55,7 +55,7 @@ public IndicesShardStoresRequest(StreamInput in) throws IOException {
         int nStatus = in.readVInt();
         statuses = EnumSet.noneOf(ClusterHealthStatus.class);
         for (int i = 0; i < nStatus; i++) {
-            statuses.add(ClusterHealthStatus.fromValue(in.readByte()));
+            statuses.add(ClusterHealthStatus.readFrom(in));
         }
         indicesOptions = IndicesOptions.readIndicesOptions(in);
     }

server/src/main/java/org/elasticsearch/cluster/health/ClusterHealthStatus.java

@@ -52,10 +52,7 @@ public void writeTo(StreamOutput out) throws IOException {
      * @throws IllegalArgumentException if the value is unrecognized
      */
     public static ClusterHealthStatus readFrom(StreamInput in) throws IOException {
-        return fromValue(in.readByte());
-    }
-
-    public static ClusterHealthStatus fromValue(byte value) throws IOException {
+        byte value = in.readByte();
         switch (value) {
             case 0:
                 return GREEN;

server/src/main/java/org/elasticsearch/cluster/health/ClusterIndexHealth.java

@@ -165,7 +165,7 @@ public ClusterIndexHealth(final StreamInput in) throws IOException {
         relocatingShards = in.readVInt();
         initializingShards = in.readVInt();
         unassignedShards = in.readVInt();
-        status = ClusterHealthStatus.fromValue(in.readByte());
+        status = ClusterHealthStatus.readFrom(in);
 
         int size = in.readVInt();
         shards = new HashMap<>(size);

server/src/main/java/org/elasticsearch/cluster/health/ClusterShardHealth.java

@@ -121,7 +121,7 @@ public ClusterShardHealth(final int shardId, final IndexShardRoutingTable shardR
 
     public ClusterShardHealth(final StreamInput in) throws IOException {
         shardId = in.readVInt();
-        status = ClusterHealthStatus.fromValue(in.readByte());
+        status = ClusterHealthStatus.readFrom(in);
         activeShards = in.readVInt();
         relocatingShards = in.readVInt();
         initializingShards = in.readVInt();

server/src/main/java/org/elasticsearch/cluster/health/ClusterStateHealth.java

@@ -134,7 +134,7 @@ public ClusterStateHealth(final StreamInput in) throws IOException {
         unassignedShards = in.readVInt();
         numberOfNodes = in.readVInt();
         numberOfDataNodes = in.readVInt();
-        status = ClusterHealthStatus.fromValue(in.readByte());
+        status = ClusterHealthStatus.readFrom(in);
         int size = in.readVInt();
         indices = new HashMap<>(size);
         for (int i = 0; i < size; i++) {