[ML] Fix rare ML daily maintenance test race condition (#64043)

Depending on thread scheduling the ML daily maintenance
tests could do one more iteration than expected, causing
rare failures.

Fixes #64036

Author: droberts195

x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/MlDailyMaintenanceServiceTests.java

@@ -230,8 +230,16 @@ private void testJobInDeletingStateDoesNotHaveDeletionTask(boolean deleted) thro
 
     private MlDailyMaintenanceService createService(CountDownLatch latch, Client client) {
         return new MlDailyMaintenanceService(Settings.EMPTY, threadPool, client, clusterService, mlAssignmentNotifier, () -> {
-                latch.countDown();
-                return TimeValue.timeValueMillis(100);
+                // We need to be careful that an unexpected iteration doesn't get squeezed in by the maintenance threadpool in
+                // between the latch getting counted down to zero and the main test thread stopping the maintenance service.
+                // This could happen if the main test thread happens to be waiting for a CPU for the whole 100ms after the
+                // latch counts down to zero.
+                if (latch.getCount() > 0) {
+                    latch.countDown();
+                    return TimeValue.timeValueMillis(100);
+                } else {
+                    return TimeValue.timeValueHours(1);
+                }
             });
     }