Skip to content

Commit 32428bf

Browse files
committed
Accept the same boolean values in RestRequest
Added `no` as a possible value to `paramBooleanAsOptional`, also reused existing code from `Booleans.parseBoolean` Closes #4808
1 parent 7129b9e commit 32428bf

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/main/java/org/elasticsearch/rest/RestRequest.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,7 @@ public boolean paramAsBoolean(String key, boolean defaultValue) {
136136

137137
@Override
138138
public Boolean paramAsBooleanOptional(String key, Boolean defaultValue) {
139-
String sValue = param(key);
140-
if (sValue == null) {
141-
return defaultValue;
142-
}
143-
return !(sValue.equals("false") || sValue.equals("0") || sValue.equals("off"));
139+
return Booleans.parseBoolean(param(key), defaultValue);
144140
}
145141

146142
public TimeValue paramAsTime(String key, TimeValue defaultValue) {

0 commit comments

Comments
 (0)