Skip to content

Commit 3c16228

Browse files
committed
Fix REST client tests
This commit fixes a few issues in the REST client tests that arose from moving to one shard. Moving to one shard causes a reordering of calculations which impacts floating-point arithmetic. It can also impact scoring and thus the ranking of docs.
1 parent 0b8ea07 commit 3c16228

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

client/rest-high-level/src/test/java/org/elasticsearch/client/SearchIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,13 @@ public void testSearchWithMatrixStats() throws IOException {
313313
assertEquals(5, matrixStats.getFieldCount("num"));
314314
assertEquals(56d, matrixStats.getMean("num"), 0d);
315315
assertEquals(1830.0000000000002, matrixStats.getVariance("num"), 0d);
316-
assertEquals(0.09340198804973046, matrixStats.getSkewness("num"), 0d);
316+
assertEquals(0.09340198804973039, matrixStats.getSkewness("num"), 0d);
317317
assertEquals(1.2741646510794589, matrixStats.getKurtosis("num"), 0d);
318318
assertEquals(5, matrixStats.getFieldCount("num2"));
319319
assertEquals(29d, matrixStats.getMean("num2"), 0d);
320320
assertEquals(330d, matrixStats.getVariance("num2"), 0d);
321321
assertEquals(-0.13568039346585542, matrixStats.getSkewness("num2"), 1.0e-16);
322-
assertEquals(1.3517561983471074, matrixStats.getKurtosis("num2"), 0d);
322+
assertEquals(1.3517561983471071, matrixStats.getKurtosis("num2"), 0d);
323323
assertEquals(-767.5, matrixStats.getCovariance("num", "num2"), 0d);
324324
assertEquals(-0.9876336291667923, matrixStats.getCorrelation("num", "num2"), 0d);
325325
}

client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/SearchDocumentationIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ public void testRankEval() throws Exception {
801801
assertEquals(1.0 / 3.0, qualityLevel, 0.0);
802802
List<RatedSearchHit> hitsAndRatings = evalQuality.getHitsAndRatings();
803803
RatedSearchHit ratedSearchHit = hitsAndRatings.get(0);
804-
assertEquals("3", ratedSearchHit.getSearchHit().getId()); // <4>
804+
assertEquals("1", ratedSearchHit.getSearchHit().getId()); // <4>
805805
assertFalse(ratedSearchHit.getRating().isPresent()); // <5>
806806
MetricDetail metricDetails = evalQuality.getMetricDetails();
807807
String metricName = metricDetails.getMetricName();

0 commit comments

Comments
 (0)