Skip to content

Commit 431f704

Browse files
committed
Move tests to elasticsearch test framework
Closes #8.
1 parent cc78694 commit 431f704

File tree

2 files changed

+29
-70
lines changed

2 files changed

+29
-70
lines changed

pom.xml

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<!-- Licensed to ElasticSearch under one or more contributor
2+
<!-- Licensed to Elasticsearch under one or more contributor
33
license agreements. See the NOTICE file distributed with this work for additional
4-
information regarding copyright ownership. ElasticSearch licenses this file to you
4+
information regarding copyright ownership. Elasticsearch licenses this file to you
55
under the Apache License, Version 2.0 (the "License"); you may not use this
66
file except in compliance with the License. You may obtain a copy of the
77
License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by
@@ -47,12 +47,25 @@ governing permissions and limitations under the License. -->
4747
</issueManagement>
4848

4949
<properties>
50-
<elasticsearch.version>0.90.3</elasticsearch.version>
50+
<elasticsearch.version>0.90.10</elasticsearch.version>
5151
<google.gce.version>v1beta15-rev3-1.15.0-rc</google.gce.version>
5252
<google.api.version>1.15.0-rc</google.api.version>
53+
<lucene.version>4.6.0</lucene.version>
54+
<tests.jvms>1</tests.jvms>
55+
<tests.shuffle>true</tests.shuffle>
56+
<tests.output>onerror</tests.output>
57+
<tests.client.ratio></tests.client.ratio>
58+
<es.logger.level>INFO</es.logger.level>
5359
</properties>
5460

5561
<dependencies>
62+
<dependency>
63+
<groupId>org.apache.lucene</groupId>
64+
<artifactId>lucene-test-framework</artifactId>
65+
<version>${lucene.version}</version>
66+
<scope>test</scope>
67+
</dependency>
68+
5669
<!-- Elasticsearch -->
5770
<dependency>
5871
<groupId>org.elasticsearch</groupId>
@@ -90,9 +103,10 @@ governing permissions and limitations under the License. -->
90103
<scope>test</scope>
91104
</dependency>
92105
<dependency>
93-
<groupId>junit</groupId>
94-
<artifactId>junit</artifactId>
95-
<version>4.11</version>
106+
<groupId>org.elasticsearch</groupId>
107+
<artifactId>elasticsearch</artifactId>
108+
<version>${elasticsearch.version}</version>
109+
<type>test-jar</type>
96110
<scope>test</scope>
97111
</dependency>
98112

src/test/java/org/elasticsearch/cloud/gce/tests/GceAbstractTest.java

Lines changed: 9 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -20,92 +20,37 @@
2020
package org.elasticsearch.cloud.gce.tests;
2121

2222
import org.elasticsearch.action.admin.cluster.node.info.NodesInfoResponse;
23-
import org.elasticsearch.client.Client;
24-
import org.elasticsearch.client.transport.TransportClient;
2523
import org.elasticsearch.cloud.gce.GceComputeService;
26-
import org.elasticsearch.common.io.FileSystemUtils;
2724
import org.elasticsearch.common.settings.ImmutableSettings;
28-
import org.elasticsearch.common.settings.Settings;
29-
import org.elasticsearch.common.transport.TransportAddress;
30-
import org.elasticsearch.node.Node;
31-
import org.elasticsearch.node.NodeBuilder;
32-
import org.elasticsearch.node.internal.InternalNode;
33-
import org.elasticsearch.transport.netty.NettyTransport;
34-
import org.junit.After;
25+
import org.elasticsearch.test.ElasticsearchIntegrationTest;
3526
import org.junit.Assert;
36-
import org.junit.Before;
3727

38-
import java.io.File;
39-
import java.util.ArrayList;
40-
import java.util.List;
28+
@ElasticsearchIntegrationTest.ClusterScope(scope = ElasticsearchIntegrationTest.Scope.TEST, numNodes = 0)
29+
public abstract class GceAbstractTest extends ElasticsearchIntegrationTest {
4130

42-
public abstract class GceAbstractTest {
43-
44-
private static List<Node> nodes;
4531
private Class<? extends GceComputeService> mock;
4632

4733
public GceAbstractTest(Class<? extends GceComputeService> mock) {
4834
// We want to inject the GCE API Mock
4935
this.mock = mock;
5036
}
5137

52-
@Before
53-
public void setUp() {
54-
nodes = new ArrayList<Node>();
55-
56-
File dataDir = new File("./target/es/data");
57-
if(dataDir.exists()) {
58-
FileSystemUtils.deleteRecursively(dataDir, true);
59-
}
60-
}
61-
62-
@After
63-
public void tearDown() {
64-
// Cleaning nodes after test
65-
for (Node node : nodes) {
66-
node.close();
67-
}
68-
}
69-
70-
protected Client getClient() {
71-
// Create a TransportClient on node 1 and 2
72-
Settings settings = ImmutableSettings.settingsBuilder()
73-
.put("cluster.name", "gce").build();
74-
75-
TransportClient client = new TransportClient(settings);
76-
77-
for (Node node : nodes) {
78-
NettyTransport nettyTransport = ((InternalNode) node).injector().getInstance(NettyTransport.class);
79-
TransportAddress transportAddress = nettyTransport.boundAddress().publishAddress();
80-
client.addTransportAddress(transportAddress);
81-
}
82-
83-
return client;
84-
}
85-
8638
protected void checkNumberOfNodes(int expected) {
87-
NodesInfoResponse nodeInfos = getClient().admin().cluster().prepareNodesInfo().execute().actionGet();
39+
NodesInfoResponse nodeInfos = client().admin().cluster().prepareNodesInfo().execute().actionGet();
8840

8941
Assert.assertNotNull(nodeInfos.getNodes());
9042
Assert.assertEquals(expected, nodeInfos.getNodes().length);
9143
}
9244

9345
protected void nodeBuilder(String filteredTags) {
94-
ImmutableSettings.Builder builder = ImmutableSettings.settingsBuilder()
95-
//.put("gateway.type", "local")
96-
.put("path.data", "./target/es/data")
97-
.put("path.logs", "./target/es/logs")
98-
.put("path.work", "./target/es/work")
46+
ImmutableSettings.Builder nodeSettings = ImmutableSettings.settingsBuilder()
9947
.put("cloud.gce.api.impl", mock)
100-
.put("cloud.gce.refresh_interval", "5s")
101-
.put("node.name", (nodes.size()+1) + "#" + mock.getSimpleName());
48+
.put("cloud.gce.refresh_interval", "5s");
10249
if (filteredTags != null) {
103-
builder.put("discovery.gce.tags", filteredTags);
50+
nodeSettings.put("discovery.gce.tags", filteredTags);
10451
} else {
105-
builder.put("discovery.gce.tags", "");
52+
nodeSettings.put("discovery.gce.tags", "");
10653
}
107-
108-
Node node = NodeBuilder.nodeBuilder().settings(builder).node();
109-
nodes.add(node);
54+
cluster().startNode(nodeSettings);
11055
}
11156
}

0 commit comments

Comments
 (0)