Skip to content

Commit 442a13a

Browse files
authored
Upgrade log4j to 2.15.0 (#81709)
Originally we tried to a log4j update in #47298, but we were unable to that due to the `DeprecationLoggerTests.testLogPermissions` test failing. The test relied on mocking and got removed in https://github.com/elastic/elasticsearch/pull/61474/files#diff-70de5a6ba5c637e7f19c51341417760d6e957beb5a1fa5703049095ea2719ee0L47 Now we should be able to the upgrade and then we can address the Security Manager permission questions raised in #47298 separately. * Initialize pattern layout with AccessController.doPrivileged We need the `getClassLoader` permissions * Disable the SecurityManager for command testing because of `CommandLoggingConfigurator` which fails under the `SecurityManager`
1 parent d00f414 commit 442a13a

File tree

46 files changed

+49
-24
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+49
-24
lines changed

build-tools-internal/version.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ snakeyaml = 1.26
1414
icu4j = 68.2
1515
supercsv = 2.4.0
1616
# when updating log4j, please update also docs/java-api/index.asciidoc
17-
log4j = 2.11.1
17+
log4j = 2.15.0
1818
slf4j = 1.6.2
1919
ecsLogging = 1.2.0
2020

modules/repository-url/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ tasks.named("thirdPartyAudit").configure {
4040
'javax.servlet.ServletContextListener',
4141
'org.apache.avalon.framework.logger.Logger',
4242
'org.apache.log.Hierarchy',
43-
'org.apache.log.Logger'
43+
'org.apache.log.Logger',
44+
'javax.jms.Message'
4445
)
4546
}
4647

modules/repository-url/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/discovery-azure-classic/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ tasks.named("thirdPartyAudit").configure {
116116
'org.apache.avalon.framework.logger.Logger',
117117
'org.apache.log.Hierarchy',
118118
'org.apache.log.Logger',
119+
'javax.jms.Message',
119120
'org.eclipse.persistence.descriptors.ClassDescriptor',
120121
'org.eclipse.persistence.internal.oxm.MappingNodeValue',
121122
'org.eclipse.persistence.internal.oxm.TreeObjectBuilder',

plugins/discovery-azure-classic/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/discovery-ec2/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ tasks.named("thirdPartyAudit").configure {
125125
'org.apache.avalon.framework.logger.Logger',
126126
'org.apache.log.Hierarchy',
127127
'org.apache.log.Logger',
128+
'javax.jms.Message',
128129
'javax.xml.bind.DatatypeConverter',
129130
'javax.xml.bind.JAXBContext'
130131
)

plugins/discovery-ec2/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/discovery-gce/build.gradle

+2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ tasks.named("thirdPartyAudit").configure {
5252
'org.apache.avalon.framework.logger.Logger',
5353
'org.apache.log.Hierarchy',
5454
'org.apache.log.Logger',
55+
'org.apache.avalon.framework.logger.Logger',
56+
'javax.jms.Message',
5557
'org.apache.http.ConnectionReuseStrategy',
5658
'org.apache.http.Header',
5759
'org.apache.http.HttpEntity',

plugins/discovery-gce/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/repository-gcs/build.gradle

+2
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ tasks.named("thirdPartyAudit").configure {
135135
'org.apache.avalon.framework.logger.Logger',
136136
'org.apache.log.Hierarchy',
137137
'org.apache.log.Logger',
138+
'javax.jms.Message',
139+
138140
// optional apache http client dependencies
139141
'org.apache.http.ConnectionReuseStrategy',
140142
'org.apache.http.Header',

plugins/repository-gcs/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/repository-hdfs/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

plugins/repository-hdfs/licenses/log4j-slf4j-impl-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

plugins/repository-s3/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,7 @@ tasks.named("thirdPartyAudit").configure {
290290
'org.apache.avalon.framework.logger.Logger',
291291
'org.apache.log.Hierarchy',
292292
'org.apache.log.Logger',
293+
'javax.jms.Message',
293294
'software.amazon.ion.IonReader',
294295
'software.amazon.ion.IonSystem',
295296
'software.amazon.ion.IonType',

plugins/repository-s3/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

server/build.gradle

-2
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,9 @@ tasks.named("thirdPartyAudit").configure {
201201
'org.apache.commons.compress.utils.IOUtils',
202202
'org.apache.commons.csv.CSVFormat',
203203
'org.apache.commons.csv.QuoteMode',
204-
'org.apache.kafka.clients.producer.Callback',
205204
'org.apache.kafka.clients.producer.Producer',
206205
'org.apache.kafka.clients.producer.RecordMetadata',
207206
'org.codehaus.stax2.XMLStreamWriter2',
208-
'org.jctools.queues.MessagePassingQueue$Consumer',
209207
'org.jctools.queues.MpscArrayQueue',
210208
'org.osgi.framework.Bundle',
211209
'org.osgi.framework.BundleActivator',

server/licenses/log4j-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
4a5aa7e55a29391c6f66e0b259d5189aa11e45d0

server/licenses/log4j-core-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ba55c13d7ac2fd44df9cc8074455719a33f375b9

x-pack/plugin/core/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ tasks.named("thirdPartyAudit").configure {
118118
'org.apache.log.Logger',
119119
//commons-logging provided dependencies
120120
'javax.servlet.ServletContextEvent',
121-
'javax.servlet.ServletContextListener'
121+
'javax.servlet.ServletContextListener',
122+
'javax.jms.Message'
122123
)
123124
}
124125

x-pack/plugin/core/licenses/log4j-1.2-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bc960fe2acbe6f3952011f88a771de18301534e7

x-pack/plugin/identity-provider/licenses/log4j-slf4j-impl-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

x-pack/plugin/security/licenses/log4j-slf4j-impl-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/audit/logfile/LoggingAuditTrailTests.java

+8-1
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@
129129
import java.nio.charset.StandardCharsets;
130130
import java.nio.file.Files;
131131
import java.nio.file.Path;
132+
import java.security.AccessController;
133+
import java.security.PrivilegedAction;
132134
import java.time.Clock;
133135
import java.util.ArrayList;
134136
import java.util.Arrays;
@@ -247,7 +249,12 @@ public static void lookupPatternLayout() throws Exception {
247249
assertThat(properties.getProperty("appender.audit_rolling.layout.type"), is("PatternLayout"));
248250
final String patternLayoutFormat = properties.getProperty("appender.audit_rolling.layout.pattern");
249251
assertThat(patternLayoutFormat, is(notNullValue()));
250-
patternLayout = PatternLayout.newBuilder().withPattern(patternLayoutFormat).withCharset(StandardCharsets.UTF_8).build();
252+
patternLayout = AccessController.doPrivileged(
253+
(PrivilegedAction<PatternLayout>) () -> PatternLayout.newBuilder()
254+
.withPattern(patternLayoutFormat)
255+
.withCharset(StandardCharsets.UTF_8)
256+
.build()
257+
);
251258
customAnonymousUsername = randomAlphaOfLength(8);
252259
reservedRealmEnabled = randomBoolean();
253260
}

x-pack/plugin/sql/qa/server/multi-node/build.gradle

+5
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,8 @@ testClusters.matching { it.name == "integTest" }.configureEach {
1212
setting 'xpack.license.self_generated.type', 'trial'
1313
plugin ':x-pack:qa:freeze-plugin'
1414
}
15+
16+
tasks.named("integTest").configure {
17+
// Disabled because of log4j Security Manager permission issues in CLI tools
18+
systemProperty 'tests.security.manager', 'false'
19+
}

x-pack/plugin/sql/qa/server/security/build.gradle

+3
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ subprojects {
5454
"${-> testClusters.integTest.singleNode().getAuditLog()}"
5555
nonInputProperties.systemProperty 'tests.audit.yesterday.logfile',
5656
"${-> testClusters.integTest.singleNode().getAuditLog().getParentFile()}/integTest_audit-${new Date().format('yyyy-MM-dd')}-1.json.gz"
57+
58+
// Disabled because of log4j Security Manager permission issues in CLI tools
59+
systemProperty 'tests.security.manager', 'false'
5760
}
5861

5962
tasks.named("testingConventions").configure { enabled = false }

x-pack/plugin/sql/qa/server/single-node/build.gradle

+5
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,8 @@ testClusters.matching { it.name == "integTest" }.configureEach {
44
setting 'xpack.license.self_generated.type', 'trial'
55
plugin ':x-pack:qa:freeze-plugin'
66
}
7+
8+
tasks.named("integTest").configure {
9+
// Disabled because of log4j Security Manager permission issues in CLI tools
10+
systemProperty 'tests.security.manager', 'false'
11+
}

x-pack/plugin/sql/sql-action/build.gradle

-2
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,9 @@ tasks.named("thirdPartyAudit").configure {
106106
'org.apache.commons.compress.utils.IOUtils',
107107
'org.apache.commons.csv.CSVFormat',
108108
'org.apache.commons.csv.QuoteMode',
109-
'org.apache.kafka.clients.producer.Callback',
110109
'org.apache.kafka.clients.producer.Producer',
111110
'org.apache.kafka.clients.producer.RecordMetadata',
112111
'org.codehaus.stax2.XMLStreamWriter2',
113-
'org.jctools.queues.MessagePassingQueue$Consumer',
114112
'org.jctools.queues.MpscArrayQueue',
115113
'org.osgi.framework.Bundle',
116114
'org.osgi.framework.BundleActivator',

x-pack/plugin/sql/sql-action/licenses/log4j-api-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
4a5aa7e55a29391c6f66e0b259d5189aa11e45d0

x-pack/plugin/sql/sql-action/licenses/log4j-core-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ba55c13d7ac2fd44df9cc8074455719a33f375b9

x-pack/plugin/vector-tile/licenses/log4j-slf4j-impl-2.11.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

0 commit comments

Comments
 (0)