Skip to content

Commit 4b9b9ed

Browse files
authored
SQL: [Tests] Unmute Pivot from NodeSublassTests (#49925)
The `testReplaceChildren()` has been fixed for Pivot as part of #49693. Reverting: #49045
1 parent dd66fae commit 4b9b9ed

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,17 @@
2828
import org.elasticsearch.xpack.sql.expression.gen.pipeline.Pipe;
2929
import org.elasticsearch.xpack.sql.expression.gen.processor.ConstantProcessor;
3030
import org.elasticsearch.xpack.sql.expression.gen.processor.Processor;
31-
import org.elasticsearch.xpack.sql.expression.predicate.conditional.Iif;
3231
import org.elasticsearch.xpack.sql.expression.predicate.conditional.IfConditional;
3332
import org.elasticsearch.xpack.sql.expression.predicate.conditional.IfNull;
33+
import org.elasticsearch.xpack.sql.expression.predicate.conditional.Iif;
3434
import org.elasticsearch.xpack.sql.expression.predicate.fulltext.FullTextPredicate;
3535
import org.elasticsearch.xpack.sql.expression.predicate.operator.comparison.In;
3636
import org.elasticsearch.xpack.sql.expression.predicate.operator.comparison.InPipe;
3737
import org.elasticsearch.xpack.sql.expression.predicate.regex.Like;
3838
import org.elasticsearch.xpack.sql.expression.predicate.regex.LikePattern;
39-
import org.elasticsearch.xpack.sql.plan.logical.Pivot;
4039
import org.elasticsearch.xpack.sql.tree.NodeTests.ChildrenAreAProperty;
4140
import org.elasticsearch.xpack.sql.tree.NodeTests.Dummy;
4241
import org.elasticsearch.xpack.sql.tree.NodeTests.NoChildren;
43-
import org.junit.Assume;
4442
import org.mockito.exceptions.base.MockitoException;
4543

4644
import java.io.IOException;
@@ -166,9 +164,6 @@ public void testTransform() throws Exception {
166164
* Test {@link Node#replaceChildren} implementation on {@link #subclass}.
167165
*/
168166
public void testReplaceChildren() throws Exception {
169-
// TODO: Provide a proper fix for: https://github.com/elastic/elasticsearch/issues/48900
170-
Assume.assumeFalse(subclass.equals(Pivot.class));
171-
172167
Constructor<T> ctor = longestCtor(subclass);
173168
Object[] nodeCtorArgs = ctorArgs(ctor);
174169
T node = ctor.newInstance(nodeCtorArgs);

0 commit comments

Comments
 (0)