Skip to content

Commit 5056f27

Browse files
authored
Skip max_buckets test when it is flaky (#58038)
Before #57042 the max_buckets test would consistently pass because the request would consistently fail. In particular, the request would fail on the data node. After #57042 it only fails on the coordinating node. When the max_buckets test is run in a mixed version cluster it consistently fails on *either* the data node or the coordinating node. Except when the coordinating node is missing #43095. In that case if the one data node has #57042 and one does not, *and* the one that doesn't gets the request first, fails it as expected, and then the coordinating node retries the request on the node with #57042. When that happens the request fails mysteriously with "partial shard failures" as the error message but not partial failures reported. This is *exactly* the bug fixed in #43095. This updates the test to be skipped in mixed version clusters without #43095 because they *sometimes* fail the test spuriously. The request fails in those cases, just like we expect, but with a mysterious error message. Closes #57657
1 parent 0906709 commit 5056f27

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/240_max_buckets.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ setup:
7676
---
7777
"Max bucket":
7878
- skip:
79-
version: " - 6.99.99"
80-
reason: search.max_buckets limit has been added in 7.0
79+
version: " - 7.2.99"
80+
reason: search.max_buckets limit has been added in 7.0 but this fails spuriously without https://github.com/elastic/elasticsearch/pull/43095 which is in 7.3.0
8181

8282
- do:
8383
cluster.put_settings:

0 commit comments

Comments
 (0)