Skip to content

Commit 5aa815a

Browse files
astefanwjweiowenniceliu
authored
[8.3] Fix object equals for SqlQueryRequest's binaryCommunication (#87887) (#89143)
* Fix object equals for SqlQueryRequest's binaryCommunication (#87887) Co-authored-by: owenniceliu <[email protected]> * fix the changelog yaml file for pr 87887 (#89146) Co-authored-by: wjwei <[email protected]> Co-authored-by: owenniceliu <[email protected]>
1 parent 6bc5f30 commit 5aa815a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

docs/changelog/87887.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 87887
2+
summary: fix object equals
3+
area: SQL
4+
type: bug
5+
issues: []

x-pack/plugin/sql/sql-action/src/main/java/org/elasticsearch/xpack/sql/action/SqlQueryRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ public boolean equals(Object obj) {
325325
return super.equals(obj)
326326
&& fieldMultiValueLeniency == ((SqlQueryRequest) obj).fieldMultiValueLeniency
327327
&& indexIncludeFrozen == ((SqlQueryRequest) obj).indexIncludeFrozen
328-
&& binaryCommunication == ((SqlQueryRequest) obj).binaryCommunication
328+
&& Objects.equals(binaryCommunication, ((SqlQueryRequest) obj).binaryCommunication)
329329
&& keepOnCompletion == ((SqlQueryRequest) obj).keepOnCompletion
330330
&& allowPartialSearchResults == ((SqlQueryRequest) obj).allowPartialSearchResults
331331
&& Objects.equals(cursor, ((SqlQueryRequest) obj).cursor)

0 commit comments

Comments
 (0)