Switch to https communication for Amazon APIs by default

We should use `https` by default instead of `http` for communication between elasticsearch and AWS API.

Note that it can be modified in case of trouble and fallback to the older setting using `cloud.aws.protocol: http`

Closes #109.

Author: dadoonet

README.md

@@ -44,19 +44,18 @@ cloud:
 
 ### Transport security
 
-By default this plugin uses HTTP for all API calls to AWS endpoints. If you wish to configure HTTPS you can set 
+By default this plugin uses HTTPS for all API calls to AWS endpoints. If you wish to configure HTTP you can set 
 `cloud.aws.protocol` in the elasticsearch config. You can optionally override this setting per individual service 
 via: `cloud.aws.ec2.protocol` or `cloud.aws.s3.protocol`. 
 
 ```
 cloud:
     aws:
-        protocol: http
+        protocol: https
         s3: 
-            protocol: https
-        ec2: 
             protocol: http
-
+        ec2: 
+            protocol: https
 ```
 
 ### Region

src/main/java/org/elasticsearch/cloud/aws/AwsEc2Service.java

@@ -60,7 +60,7 @@ public synchronized AmazonEC2 client() {
         }
 
         ClientConfiguration clientConfiguration = new ClientConfiguration();
-        String protocol = componentSettings.get("protocol", "http").toLowerCase();
+        String protocol = componentSettings.get("protocol", "https").toLowerCase();
         protocol = componentSettings.get("ec2.protocol", protocol).toLowerCase();
         if ("http".equals(protocol)) {
             clientConfiguration.setProtocol(Protocol.HTTP);

src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java

@@ -19,9 +19,6 @@
 
 package org.elasticsearch.cloud.aws;
 
-import java.util.HashMap;
-import java.util.Map;
-
 import com.amazonaws.ClientConfiguration;
 import com.amazonaws.Protocol;
 import com.amazonaws.auth.*;
@@ -36,6 +33,9 @@
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.settings.SettingsFilter;
 
+import java.util.HashMap;
+import java.util.Map;
+
 /**
  *
  */
@@ -88,7 +88,7 @@ private synchronized AmazonS3 getClient(String endpoint, String account, String
         }
 
         ClientConfiguration clientConfiguration = new ClientConfiguration();
-        String protocol = componentSettings.get("protocol", "http").toLowerCase();
+        String protocol = componentSettings.get("protocol", "https").toLowerCase();
         protocol = componentSettings.get("s3.protocol", protocol).toLowerCase();
         if ("http".equals(protocol)) {
             clientConfiguration.setProtocol(Protocol.HTTP);