Enhance TransportReplicationAction assertions (#49081)

Include failure into assertion error when replication action discovers
that it has been double triggered.

Author: henningandersen

server/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java

@@ -792,7 +792,7 @@ void finishAsFailed(Exception failure) {
                 logger.trace(() -> new ParameterizedMessage("operation failed. action [{}], request [{}]", actionName, request), failure);
                 listener.onFailure(failure);
             } else {
-                assert false : "finishAsFailed called but operation is already finished";
+                assert false : new AssertionError("finishAsFailed called but operation is already finished", failure);
             }
         }
 
@@ -804,7 +804,7 @@ void finishWithUnexpectedFailure(Exception failure) {
                 setPhase(task, "failed");
                 listener.onFailure(failure);
             } else {
-                assert false : "finishWithUnexpectedFailure called but operation is already finished";
+                assert false : new AssertionError("finishWithUnexpectedFailure called but operation is already finished", failure);
             }
         }