Verify distro archives do not contain plain class files (#59073) (#59229)

This is a test to ensure we do not run into a regression like we did in
#59031

Author: breskeby

distribution/archives/build.gradle

@@ -27,7 +27,7 @@ import org.elasticsearch.gradle.VersionProperties
 import org.elasticsearch.gradle.info.BuildParams
 import org.elasticsearch.gradle.plugin.PluginBuildPlugin
 import org.elasticsearch.gradle.tar.SymbolicLinkPreservingTar
-
+import groovy.io.FileType
 import java.nio.file.Files
 import java.nio.file.Path
 
@@ -245,6 +245,13 @@ subprojects {
       project.delete(archiveExtractionDir)
       archiveExtractionDir.mkdirs()
     }
+    // common sanity checks on extracted archive directly as part of checkExtraction
+    doLast {
+      // check no plain class files are packaged
+      archiveExtractionDir.eachFileRecurse (FileType.FILES) { file ->
+        assert file.name.endsWith(".class") == false
+      }
+    }
   }
   tasks.named('check').configure { dependsOn checkExtraction }
   if (project.name.contains('tar')) {