move security confirmation after 'plugin already installed' check, to prevent user from answering unnecessary questions.

Author: rmuir

core/src/main/java/org/elasticsearch/plugins/PluginManager.java

@@ -220,13 +220,6 @@ private void extract(PluginHandle pluginHandle, Terminal terminal, Path pluginFi
         PluginInfo info = PluginInfo.readFromProperties(root);
         terminal.println(VERBOSE, "%s", info);
 
-        // read optional security policy (extra permissions)
-        // if it exists, confirm or warn the user
-        Path policy = root.resolve(PluginInfo.ES_PLUGIN_POLICY);
-        if (Files.exists(policy)) {
-            PluginSecurity.readPolicy(policy, terminal, environment, batch);
-        }
-
         // check for jar hell before any copying
         if (info.isJvm()) {
             jarHellCheck(root, info.isIsolated());
@@ -239,6 +232,13 @@ private void extract(PluginHandle pluginHandle, Terminal terminal, Path pluginFi
             throw new IOException("plugin directory " + extractLocation.toAbsolutePath() + " already exists. To update the plugin, uninstall it first using 'remove " + pluginHandle.name + "' command");
         }
 
+        // read optional security policy (extra permissions)
+        // if it exists, confirm or warn the user
+        Path policy = root.resolve(PluginInfo.ES_PLUGIN_POLICY);
+        if (Files.exists(policy)) {
+            PluginSecurity.readPolicy(policy, terminal, environment, batch);
+        }
+
         // install plugin
         FileSystemUtils.copyDirectoryRecursively(root, extractLocation);
         terminal.println("Installed %s into %s", pluginHandle.name, extractLocation.toAbsolutePath());