Skip to content

Commit 73be1d9

Browse files
Address Nik's feedback
1 parent a6ea516 commit 73be1d9

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

rest-api-spec/src/main/resources/rest-api-spec/test/search/350_binary_field.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,11 @@
2020
Content-Type: application/json
2121
index:
2222
index: test
23+
refresh: true
2324
id: 1
2425
body:
2526
binary: U29tZSBiaW5hcnkgYmxvYg==
2627

27-
- do:
28-
indices.refresh: {}
29-
3028
- do:
3129
search:
3230
index: test

server/src/test/java/org/elasticsearch/index/mapper/BinaryFieldMapperTests.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919

2020
import java.io.IOException;
2121
import java.io.OutputStream;
22+
import java.nio.charset.StandardCharsets;
2223
import java.util.Arrays;
24+
import java.util.Base64;
2325

2426
import static org.hamcrest.Matchers.instanceOf;
2527

@@ -121,9 +123,12 @@ public void testStoredValue() throws IOException {
121123

122124
@Override
123125
protected Object generateRandomInputValue(MappedFieldType ft) {
124-
assumeFalse("We can't parse the binary doc values we send", true);
125-
// AwaitsFix https://github.com/elastic/elasticsearch/issues/70244
126-
return null;
126+
if (rarely()) {
127+
return null;
128+
} else {
129+
byte[] value = randomAlphaOfLengthBetween(1, 30).getBytes(StandardCharsets.UTF_8);
130+
return Base64.getEncoder().encodeToString(value);
131+
}
127132
}
128133

129134
@Override

0 commit comments

Comments
 (0)