Adjust .DS_Store test assertions on Windows

Windows handles trying to read a file that does not exist because a
component of the path is not a directory differently than other OS
handle this situation. This commit adjusts these assertions for Windows.

Author: jasontedor

core/src/test/java/org/elasticsearch/plugins/PluginsServiceTests.java

@@ -30,6 +30,7 @@
 import java.io.IOException;
 import java.nio.file.FileSystemException;
 import java.nio.file.Files;
+import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import java.util.Arrays;
 import java.util.Collection;
@@ -145,7 +146,11 @@ public void testDesktopServicesStoreFiles() throws IOException {
             assertThat(e, hasToString(containsString("Could not load plugin descriptor for existing plugin [.DS_Store]")));
             assertNotNull(e.getCause());
             assertThat(e.getCause(), instanceOf(FileSystemException.class));
-            assertThat(e.getCause(), hasToString(containsString("Not a directory")));
+            if (Constants.WINDOWS) {
+                assertThat(e.getCause(), instanceOf(NoSuchFileException.class));
+            } else {
+                assertThat(e.getCause(), hasToString(containsString("Not a directory")));
+            }
         }
     }
 

qa/no-bootstrap-tests/src/test/java/org/elasticsearch/bootstrap/SpawnerNoBootstrapTests.java

@@ -33,6 +33,7 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.FileSystemException;
 import java.nio.file.Files;
+import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
 import java.nio.file.attribute.PosixFileAttributeView;
 import java.nio.file.attribute.PosixFilePermission;
@@ -45,6 +46,7 @@
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.hasToString;
+import static org.hamcrest.Matchers.instanceOf;
 
 /**
  * Create a simple "daemon controller", put it in the right place and check that it runs.
@@ -211,7 +213,11 @@ public void testSpawnerHandlingOfDesktopServicesStoreFiles() throws IOException
             // we do not ignore these files on non-macOS systems
             final FileSystemException e =
                     expectThrows(FileSystemException.class, () -> spawner.spawnNativePluginControllers(environment));
-            assertThat(e, hasToString(containsString("Not a directory")));
+            if (Constants.WINDOWS) {
+                assertThat(e, instanceOf(NoSuchFileException.class));
+            } else {
+                assertThat(e, hasToString(containsString("Not a directory")));
+            }
         }
     }