Core: Create java time based DateMathParser (#32131)

This adds a java time based date math parser class in order, which will replace the joda date based one in the future. For now the class also returns the date in milliseconds since the epoch.

Author: spinscale

server/src/main/java/org/elasticsearch/common/time/CompoundDateTimeFormatter.java

@@ -20,22 +20,36 @@
 
 import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeFormatterBuilder;
 import java.time.format.DateTimeParseException;
 import java.time.temporal.TemporalAccessor;
+import java.time.temporal.TemporalField;
+import java.util.Arrays;
+import java.util.Locale;
+import java.util.Map;
+import java.util.function.Consumer;
 
 /**
  * wrapper class around java.time.DateTimeFormatter that supports multiple formats for easier parsing,
  * and one specific format for printing
  */
 public class CompoundDateTimeFormatter {
 
+    private static final Consumer<DateTimeFormatter[]> SAME_TIME_ZONE_VALIDATOR = (parsers) -> {
+        long distinctZones = Arrays.stream(parsers).map(DateTimeFormatter::getZone).distinct().count();
+        if (distinctZones > 1) {
+            throw new IllegalArgumentException("formatters must have the same time zone");
+        }
+    };
+
     final DateTimeFormatter printer;
     final DateTimeFormatter[] parsers;
 
     CompoundDateTimeFormatter(DateTimeFormatter ... parsers) {
         if (parsers.length == 0) {
             throw new IllegalArgumentException("at least one date time formatter is required");
         }
+        SAME_TIME_ZONE_VALIDATOR.accept(parsers);
         this.printer = parsers[0];
         this.parsers = parsers;
     }
@@ -58,7 +72,18 @@ public TemporalAccessor parse(String input) {
         throw failure;
     }
 
+    /**
+     * Configure a specific time zone for a date formatter
+     *
+     * @param zoneId The zoneId this formatter shoulduse
+     * @return       The new formatter with all parsers switched to the specified timezone
+     */
     public CompoundDateTimeFormatter withZone(ZoneId zoneId) {
+        // shortcurt to not create new objects unnecessarily
+        if (zoneId.equals(parsers[0].getZone())) {
+            return this;
+        }
+
         final DateTimeFormatter[] parsersWithZone = new DateTimeFormatter[parsers.length];
         for (int i = 0; i < parsers.length; i++) {
             parsersWithZone[i] = parsers[i].withZone(zoneId);
@@ -67,6 +92,20 @@ public CompoundDateTimeFormatter withZone(ZoneId zoneId) {
         return new CompoundDateTimeFormatter(parsersWithZone);
     }
 
+    /**
+     * Configure defaults for missing values in a parser, then return a new compound date formatter
+     */
+    CompoundDateTimeFormatter parseDefaulting(Map<TemporalField, Long> fields) {
+        final DateTimeFormatter[] parsersWithDefaulting = new DateTimeFormatter[parsers.length];
+        for (int i = 0; i < parsers.length; i++) {
+            DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder().append(parsers[i]);
+            fields.forEach(builder::parseDefaulting);
+            parsersWithDefaulting[i] = builder.toFormatter(Locale.ROOT);
+        }
+
+        return new CompoundDateTimeFormatter(parsersWithDefaulting);
+    }
+
     public String format(TemporalAccessor accessor) {
         return printer.format(accessor);
     }

server/src/main/java/org/elasticsearch/common/time/DateFormatters.java

@@ -701,11 +701,15 @@ public class DateFormatters {
     /////////////////////////////////////////
 
     private static final DateTimeFormatter DATE_FORMATTER = new DateTimeFormatterBuilder()
-        .appendValue(ChronoField.YEAR, 1, 4, SignStyle.NORMAL)
+        .appendValue(ChronoField.YEAR, 1, 5, SignStyle.NORMAL)
+        .optionalStart()
         .appendLiteral('-')
         .appendValue(MONTH_OF_YEAR, 1, 2, SignStyle.NOT_NEGATIVE)
+        .optionalStart()
         .appendLiteral('-')
         .appendValue(DAY_OF_MONTH, 1, 2, SignStyle.NOT_NEGATIVE)
+        .optionalEnd()
+        .optionalEnd()
         .toFormatter(Locale.ROOT);
 
     private static final DateTimeFormatter HOUR_MINUTE_FORMATTER = new DateTimeFormatterBuilder()
@@ -723,7 +727,11 @@ public class DateFormatters {
             .append(DATE_FORMATTER)
             .optionalStart()
             .appendLiteral('T')
-            .append(HOUR_MINUTE_FORMATTER)
+            .optionalStart()
+            .appendValue(HOUR_OF_DAY, 1, 2, SignStyle.NOT_NEGATIVE)
+            .optionalStart()
+            .appendLiteral(':')
+            .appendValue(MINUTE_OF_HOUR, 1, 2, SignStyle.NOT_NEGATIVE)
             .optionalStart()
             .appendLiteral(':')
             .appendValue(SECOND_OF_MINUTE, 1, 2, SignStyle.NOT_NEGATIVE)
@@ -733,12 +741,18 @@ public class DateFormatters {
             .optionalEnd()
             .optionalStart().appendZoneOrOffsetId().optionalEnd()
             .optionalEnd()
+            .optionalEnd()
+            .optionalEnd()
             .toFormatter(Locale.ROOT),
         new DateTimeFormatterBuilder()
             .append(DATE_FORMATTER)
             .optionalStart()
             .appendLiteral('T')
-            .append(HOUR_MINUTE_FORMATTER)
+            .optionalStart()
+            .appendValue(HOUR_OF_DAY, 1, 2, SignStyle.NOT_NEGATIVE)
+            .optionalStart()
+            .appendLiteral(':')
+            .appendValue(MINUTE_OF_HOUR, 1, 2, SignStyle.NOT_NEGATIVE)
             .optionalStart()
             .appendLiteral(':')
             .appendValue(SECOND_OF_MINUTE, 1, 2, SignStyle.NOT_NEGATIVE)
@@ -748,6 +762,8 @@ public class DateFormatters {
             .optionalEnd()
             .optionalStart().appendOffset("+HHmm", "Z").optionalEnd()
             .optionalEnd()
+            .optionalEnd()
+            .optionalEnd()
             .toFormatter(Locale.ROOT));
 
     private static final DateTimeFormatter HOUR_MINUTE_SECOND_FORMATTER = new DateTimeFormatterBuilder()