Increase the sample space for random inner hits name generator (#42057) (#42073)

bizybot · web-flow · commit 826642266ccd · 2019-05-12T10:32:45.000+10:00
This commits changes the minimum length for inner hits
name to avoid name collision which sometimes failed the
test.
diff --git a/server/src/test/java/org/elasticsearch/index/query/InnerHitBuilderTests.java b/server/src/test/java/org/elasticsearch/index/query/InnerHitBuilderTests.java
@@ -146,7 +146,7 @@ public static InnerHitBuilder randomNestedInnerHits() {
     }
     public static InnerHitBuilder randomInnerHits() {
         InnerHitBuilder innerHits = new InnerHitBuilder();
-        innerHits.setName(randomAlphaOfLengthBetween(1, 16));
+        innerHits.setName(randomAlphaOfLengthBetween(5, 16));
         innerHits.setFrom(randomIntBetween(0, 32));
         innerHits.setSize(randomIntBetween(0, 32));
         innerHits.setExplain(randomBoolean());

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public static InnerHitBuilder randomNestedInnerHits() {`
`146`	`146`	`}`
`147`	`147`	`public static InnerHitBuilder randomInnerHits() {`
`148`	`148`	`InnerHitBuilder innerHits = new InnerHitBuilder();`
`149`		`- innerHits.setName(randomAlphaOfLengthBetween(1, 16));`
	`149`	`+ innerHits.setName(randomAlphaOfLengthBetween(5, 16));`
`150`	`150`	`innerHits.setFrom(randomIntBetween(0, 32));`
`151`	`151`	`innerHits.setSize(randomIntBetween(0, 32));`
`152`	`152`	`innerHits.setExplain(randomBoolean());`