Add unit test

Author: ivange94

server/src/main/java/org/elasticsearch/index/reindex/ReindexRequest.java

@@ -38,7 +38,6 @@
 import java.io.IOException;
 
 import static org.elasticsearch.action.ValidateActions.addValidationError;
-import static org.elasticsearch.index.VersionType.EXTERNAL;
 import static org.elasticsearch.index.VersionType.INTERNAL;
 
 /**

server/src/test/java/org/elasticsearch/index/reindex/ReindexRequestTests.java

@@ -21,11 +21,13 @@
 
 import org.elasticsearch.action.ActionRequestValidationException;
 import org.elasticsearch.common.bytes.BytesArray;
+import org.elasticsearch.index.VersionType;
 import org.elasticsearch.search.slice.SliceBuilder;
 
 import static java.util.Collections.emptyMap;
 import static org.elasticsearch.common.unit.TimeValue.parseTimeValue;
 import static org.elasticsearch.index.query.QueryBuilders.matchAllQuery;
+import static org.hamcrest.CoreMatchers.is;
 
 /**
  * Tests some of the validation of {@linkplain ReindexRequest}. See reindex's rest tests for much more.
@@ -65,6 +67,14 @@ public void testNoSliceBuilderSetWithSlicedRequest() {
         assertEquals("Validation Failed: 1: can't specify both manual and automatic slicing at the same time;", e.getMessage());
     }
 
+    public void testReindexShouldThrowErrorWhenCreateIsUsedWithCreate() {
+        ReindexRequest reindex = newRequest();
+        reindex.setDestOpType("create");
+        reindex.setDestVersionType(VersionType.EXTERNAL);
+        ActionRequestValidationException e = reindex.validate();
+        assertThat(e.getMessage(), is("Validation Failed: 1: create operations only support internal versioning. use index instead;"));
+    }
+
     @Override
     protected void extraRandomizationForSlice(ReindexRequest original) {
         if (randomBoolean()) {