Skip to content

Commit 8a54a05

Browse files
Fix Offset Mistake in ChunkedBlobOutputStreamTests (#74735)
Obvious mistake/oversight here that fails tests for buffers of length `1`.
1 parent 9b15e1a commit 8a54a05

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

server/src/test/java/org/elasticsearch/repositories/blobstore/ChunkedBlobOutputStreamTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ protected void onFailure() {
7979
while (written < bytesToWrite) {
8080
if (randomBoolean()) {
8181
random().nextBytes(buffer);
82-
final int offset = randomInt(buffer.length - 2) + 1;
82+
final int offset = randomInt(buffer.length - 1);
8383
final int length = Math.toIntExact(Math.min(bytesToWrite - written, buffer.length - offset));
8484
stream.write(buffer, offset, length);
8585
checksumIn.update(buffer, offset, length);
@@ -133,7 +133,7 @@ protected void onFailure() {
133133
break;
134134
} else if (randomBoolean()) {
135135
random().nextBytes(buffer);
136-
final int offset = randomInt(buffer.length - 2) + 1;
136+
final int offset = randomInt(buffer.length - 1);
137137
final int length = Math.toIntExact(Math.min(bytesToWrite - written, buffer.length - offset));
138138
stream.write(buffer, offset, length);
139139
written += length;

0 commit comments

Comments
 (0)