Skip to content

Commit 92fa914

Browse files
committed
rename more before() methods that now conflict with ESTestCase
1 parent 087a85a commit 92fa914

10 files changed

+14
-53
lines changed

core/src/test/java/org/elasticsearch/index/fielddata/ParentChildFieldDataTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public class ParentChildFieldDataTests extends AbstractFieldDataTestCase {
6060
private final String grandChildType = "grand-child";
6161

6262
@Before
63-
public void before() throws Exception {
63+
public void setupData() throws Exception {
6464
mapperService.merge(
6565
childType, new CompressedXContent(PutMappingRequest.buildFromSimplifiedDef(childType, "_parent", "type=" + parentType).string()), MapperService.MergeReason.MAPPING_UPDATE, false
6666
);

core/src/test/java/org/elasticsearch/index/mapper/AbstractNumericFieldMapperTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public abstract class AbstractNumericFieldMapperTestCase extends ESSingleNodeTes
4343
protected DocumentMapperParser parser;
4444

4545
@Before
46-
public void before() {
46+
public void setup() {
4747
indexService = createIndex("test");
4848
parser = indexService.mapperService().documentMapperParser();
4949
setTypeList();

core/src/test/java/org/elasticsearch/index/mapper/BooleanFieldMapperTests.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,31 +30,21 @@
3030
import org.apache.lucene.store.Directory;
3131
import org.apache.lucene.store.RAMDirectory;
3232
import org.apache.lucene.util.BytesRef;
33-
import org.elasticsearch.Version;
34-
import org.elasticsearch.cluster.metadata.IndexMetaData;
3533
import org.elasticsearch.common.bytes.BytesReference;
3634
import org.elasticsearch.common.compress.CompressedXContent;
37-
import org.elasticsearch.common.settings.Settings;
3835
import org.elasticsearch.common.xcontent.ToXContent;
3936
import org.elasticsearch.common.xcontent.XContentBuilder;
4037
import org.elasticsearch.common.xcontent.XContentFactory;
4138
import org.elasticsearch.index.IndexService;
42-
import org.elasticsearch.index.mapper.DocumentMapper;
43-
import org.elasticsearch.index.mapper.DocumentMapperParser;
44-
import org.elasticsearch.index.mapper.FieldMapper;
45-
import org.elasticsearch.index.mapper.MapperService;
46-
import org.elasticsearch.index.mapper.ParsedDocument;
4739
import org.elasticsearch.index.mapper.ParseContext.Document;
4840
import org.elasticsearch.plugins.Plugin;
4941
import org.elasticsearch.test.ESSingleNodeTestCase;
5042
import org.elasticsearch.test.InternalSettingsPlugin;
51-
import org.elasticsearch.test.VersionUtils;
5243
import org.junit.Before;
5344

5445
import java.io.IOException;
5546
import java.util.Collection;
5647

57-
import static com.carrotsearch.randomizedtesting.RandomizedTest.getRandom;
5848
import static org.hamcrest.Matchers.containsString;
5949

6050
public class BooleanFieldMapperTests extends ESSingleNodeTestCase {
@@ -63,7 +53,7 @@ public class BooleanFieldMapperTests extends ESSingleNodeTestCase {
6353
DocumentMapperParser parser;
6454

6555
@Before
66-
public void before() {
56+
public void setup() {
6757
indexService = createIndex("test");
6858
parser = indexService.mapperService().documentMapperParser();
6959
}

core/src/test/java/org/elasticsearch/index/mapper/DateFieldMapperTests.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,12 @@
2121

2222
import org.apache.lucene.index.DocValuesType;
2323
import org.apache.lucene.index.IndexableField;
24-
import org.elasticsearch.Version;
25-
import org.elasticsearch.cluster.metadata.IndexMetaData;
2624
import org.elasticsearch.common.compress.CompressedXContent;
27-
import org.elasticsearch.common.settings.Settings;
2825
import org.elasticsearch.common.xcontent.XContentFactory;
2926
import org.elasticsearch.index.IndexService;
3027
import org.elasticsearch.plugins.Plugin;
3128
import org.elasticsearch.test.ESSingleNodeTestCase;
3229
import org.elasticsearch.test.InternalSettingsPlugin;
33-
import org.elasticsearch.test.VersionUtils;
3430
import org.joda.time.DateTime;
3531
import org.joda.time.DateTimeZone;
3632
import org.joda.time.format.DateTimeFormat;
@@ -39,7 +35,6 @@
3935
import java.io.IOException;
4036
import java.util.Collection;
4137

42-
import static com.carrotsearch.randomizedtesting.RandomizedTest.getRandom;
4338
import static org.hamcrest.Matchers.containsString;
4439

4540
public class DateFieldMapperTests extends ESSingleNodeTestCase {
@@ -48,7 +43,7 @@ public class DateFieldMapperTests extends ESSingleNodeTestCase {
4843
DocumentMapperParser parser;
4944

5045
@Before
51-
public void before() {
46+
public void setup() {
5247
indexService = createIndex("test");
5348
parser = indexService.mapperService().documentMapperParser();
5449
}

core/src/test/java/org/elasticsearch/index/mapper/IpFieldMapperTests.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,40 +23,30 @@
2323
import org.apache.lucene.index.DocValuesType;
2424
import org.apache.lucene.index.IndexableField;
2525
import org.apache.lucene.util.BytesRef;
26-
import org.elasticsearch.Version;
27-
import org.elasticsearch.cluster.metadata.IndexMetaData;
2826
import org.elasticsearch.common.compress.CompressedXContent;
2927
import org.elasticsearch.common.network.InetAddresses;
30-
import org.elasticsearch.common.settings.Settings;
3128
import org.elasticsearch.common.xcontent.ToXContent;
3229
import org.elasticsearch.common.xcontent.XContentBuilder;
3330
import org.elasticsearch.common.xcontent.XContentFactory;
3431
import org.elasticsearch.index.IndexService;
35-
import org.elasticsearch.index.mapper.DocumentMapper;
36-
import org.elasticsearch.index.mapper.DocumentMapperParser;
37-
import org.elasticsearch.index.mapper.IpFieldMapper;
38-
import org.elasticsearch.index.mapper.MapperParsingException;
39-
import org.elasticsearch.index.mapper.ParsedDocument;
4032
import org.elasticsearch.plugins.Plugin;
4133
import org.elasticsearch.test.ESSingleNodeTestCase;
4234
import org.elasticsearch.test.InternalSettingsPlugin;
43-
import org.elasticsearch.test.VersionUtils;
4435
import org.junit.Before;
4536

46-
import static com.carrotsearch.randomizedtesting.RandomizedTest.getRandom;
47-
import static org.hamcrest.Matchers.containsString;
48-
4937
import java.io.IOException;
5038
import java.net.InetAddress;
5139
import java.util.Collection;
5240

41+
import static org.hamcrest.Matchers.containsString;
42+
5343
public class IpFieldMapperTests extends ESSingleNodeTestCase {
5444

5545
IndexService indexService;
5646
DocumentMapperParser parser;
5747

5848
@Before
59-
public void before() {
49+
public void setup() {
6050
indexService = createIndex("test");
6151
parser = indexService.mapperService().documentMapperParser();
6252
}

core/src/test/java/org/elasticsearch/index/mapper/KeywordFieldMapperTests.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,18 @@
2424
import org.apache.lucene.index.IndexableField;
2525
import org.apache.lucene.index.IndexableFieldType;
2626
import org.apache.lucene.util.BytesRef;
27-
import org.elasticsearch.Version;
28-
import org.elasticsearch.cluster.metadata.IndexMetaData;
2927
import org.elasticsearch.common.compress.CompressedXContent;
30-
import org.elasticsearch.common.settings.Settings;
3128
import org.elasticsearch.common.xcontent.XContentFactory;
3229
import org.elasticsearch.index.IndexService;
3330
import org.elasticsearch.plugins.Plugin;
3431
import org.elasticsearch.test.ESSingleNodeTestCase;
3532
import org.elasticsearch.test.InternalSettingsPlugin;
36-
import org.elasticsearch.test.VersionUtils;
3733
import org.junit.Before;
3834

3935
import java.io.IOException;
4036
import java.util.Arrays;
4137
import java.util.Collection;
4238

43-
import static com.carrotsearch.randomizedtesting.RandomizedTest.getRandom;
4439
import static org.hamcrest.Matchers.containsString;
4540
import static org.hamcrest.Matchers.equalTo;
4641

@@ -55,7 +50,7 @@ protected Collection<Class<? extends Plugin>> getPlugins() {
5550
DocumentMapperParser parser;
5651

5752
@Before
58-
public void before() {
53+
public void setup() {
5954
indexService = createIndex("test");
6055
parser = indexService.mapperService().documentMapperParser();
6156
}

core/src/test/java/org/elasticsearch/index/mapper/ScaledFloatFieldMapperTests.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@
2424
import org.elasticsearch.common.compress.CompressedXContent;
2525
import org.elasticsearch.common.xcontent.XContentFactory;
2626
import org.elasticsearch.index.IndexService;
27-
import org.elasticsearch.index.mapper.DocumentMapper;
28-
import org.elasticsearch.index.mapper.DocumentMapperParser;
29-
import org.elasticsearch.index.mapper.MapperParsingException;
30-
import org.elasticsearch.index.mapper.ParsedDocument;
3127
import org.elasticsearch.plugins.Plugin;
3228
import org.elasticsearch.test.ESSingleNodeTestCase;
3329
import org.elasticsearch.test.InternalSettingsPlugin;
@@ -44,7 +40,7 @@ public class ScaledFloatFieldMapperTests extends ESSingleNodeTestCase {
4440
DocumentMapperParser parser;
4541

4642
@Before
47-
public void before() {
43+
public void setup() {
4844
indexService = createIndex("test");
4945
parser = indexService.mapperService().documentMapperParser();
5046
}

core/src/test/java/org/elasticsearch/index/mapper/TextFieldMapperTests.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,7 @@
2828
import org.apache.lucene.index.Term;
2929
import org.apache.lucene.index.TermsEnum;
3030
import org.apache.lucene.util.BytesRef;
31-
import org.elasticsearch.Version;
32-
import org.elasticsearch.cluster.metadata.IndexMetaData;
3331
import org.elasticsearch.common.compress.CompressedXContent;
34-
import org.elasticsearch.common.settings.Settings;
3532
import org.elasticsearch.common.xcontent.ToXContent;
3633
import org.elasticsearch.common.xcontent.XContentBuilder;
3734
import org.elasticsearch.common.xcontent.XContentFactory;
@@ -43,7 +40,6 @@
4340
import org.elasticsearch.plugins.Plugin;
4441
import org.elasticsearch.test.ESSingleNodeTestCase;
4542
import org.elasticsearch.test.InternalSettingsPlugin;
46-
import org.elasticsearch.test.VersionUtils;
4743
import org.junit.Before;
4844

4945
import java.io.IOException;
@@ -53,7 +49,6 @@
5349
import java.util.HashMap;
5450
import java.util.Map;
5551

56-
import static com.carrotsearch.randomizedtesting.RandomizedTest.getRandom;
5752
import static org.hamcrest.Matchers.containsString;
5853
import static org.hamcrest.Matchers.equalTo;
5954

@@ -63,7 +58,7 @@ public class TextFieldMapperTests extends ESSingleNodeTestCase {
6358
DocumentMapperParser parser;
6459

6560
@Before
66-
public void before() {
61+
public void setup() {
6762
indexService = createIndex("test");
6863
parser = indexService.mapperService().documentMapperParser();
6964
}

core/src/test/java/org/elasticsearch/search/SearchCancellationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class SearchCancellationTests extends ESTestCase {
4444
static IndexReader reader;
4545

4646
@BeforeClass
47-
public static void before() throws IOException {
47+
public static void setup() throws IOException {
4848
dir = newDirectory();
4949
RandomIndexWriter w = new RandomIndexWriter(random(), dir);
5050
// we need at least 2 segments - so no merges should be allowed
@@ -66,7 +66,7 @@ private static void indexRandomDocuments(RandomIndexWriter w, int numDocs) throw
6666
}
6767

6868
@AfterClass
69-
public static void after() throws IOException {
69+
public static void cleanup() throws IOException {
7070
IOUtils.close(reader, dir);
7171
dir = null;
7272
reader = null;

core/src/test/java/org/elasticsearch/search/profile/query/QueryProfilerTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public class QueryProfilerTests extends ESTestCase {
5656
static ContextIndexSearcher searcher;
5757

5858
@BeforeClass
59-
public static void before() throws IOException {
59+
public static void setup() throws IOException {
6060
dir = newDirectory();
6161
RandomIndexWriter w = new RandomIndexWriter(random(), dir);
6262
final int numDocs = TestUtil.nextInt(random(), 1, 20);
@@ -76,7 +76,7 @@ public static void before() throws IOException {
7676
}
7777

7878
@AfterClass
79-
public static void after() throws IOException {
79+
public static void cleanup() throws IOException {
8080
IOUtils.close(reader, dir);
8181
dir = null;
8282
reader = null;

0 commit comments

Comments
 (0)