Skip to content

Commit a36ec74

Browse files
committed
Add deprecation notice for missing option
Relates #29465
1 parent 2997bb2 commit a36ec74

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

docs/reference/migration/migrate_6_0/aggregations.asciidoc

+6-1
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,9 @@ If the `format` in the mappings is not compatible with the numeric input value,
6363

6464
The execution hints `global_ordinals_hash` and `global_ordinals_low_cardinality` are deprecated and should be replaced
6565
by `global_ordinals` which now internally choose whether it should remap global ordinals to dense ordinals or directly use the
66-
segment ordinals.
66+
segment ordinals.
67+
68+
==== `missing` is deprecated in the `composite` aggregation
69+
70+
The `missing` option of the `composite` aggregation is deprecated, `missing_bucket`
71+
should be used instead.

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/230_composite.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@ setup:
327327
---
328328
"Composite aggregation and array size":
329329
- skip:
330-
version: " - 6.99.99"
331-
reason: starting in 7.0 the composite sources do not allocate arrays eagerly.
330+
version: " - 6.3.99"
331+
reason: starting in 6.4 the composite sources do not allocate arrays eagerly.
332332

333333
- do:
334334
search:

server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesSourceBuilder.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public abstract class CompositeValuesSourceBuilder<AB extends CompositeValuesSou
7272
if (in.readBoolean()) {
7373
this.valueType = ValueType.readFromStream(in);
7474
}
75-
if (in.getVersion().onOrAfter(Version.V_7_0_0_alpha1)) {
75+
if (in.getVersion().onOrAfter(Version.V_6_4_0)) {
7676
this.missingBucket = in.readBoolean();
7777
} else {
7878
this.missingBucket = false;
@@ -100,7 +100,7 @@ public final void writeTo(StreamOutput out) throws IOException {
100100
if (hasValueType) {
101101
valueType.writeTo(out);
102102
}
103-
if (out.getVersion().onOrAfter(Version.V_7_0_0_alpha1)) {
103+
if (out.getVersion().onOrAfter(Version.V_6_4_0)) {
104104
out.writeBoolean(missingBucket);
105105
}
106106
out.writeGenericValue(missing);

0 commit comments

Comments
 (0)