Return 0 instead of -1 for unknown/non-exposed ramBytesUsed()

The accountable interface specifies that such values are illegal

Fixes #8239

Author: dakrone

src/main/java/org/elasticsearch/index/fielddata/plain/BinaryDVAtomicFieldData.java

@@ -63,7 +63,7 @@ public void close() {
 
     @Override
     public long ramBytesUsed() {
-        return -1; // unknown
+        return 0; // unknown
     }
 
 }

src/main/java/org/elasticsearch/index/fielddata/plain/BinaryDVNumericIndexFieldData.java

@@ -84,7 +84,7 @@ public SortedNumericDoubleValues getDoubleValues() {
 
                 };
             } else {
-                return new AtomicLongFieldData(-1) {
+                return new AtomicLongFieldData(0) {
 
                     @Override
                     public SortedNumericDocValues getLongValues() {

src/main/java/org/elasticsearch/index/fielddata/plain/BytesBinaryDVAtomicFieldData.java

@@ -42,7 +42,7 @@ final class BytesBinaryDVAtomicFieldData implements AtomicFieldData {
 
     @Override
     public long ramBytesUsed() {
-        return -1; // not exposed by Lucene
+        return 0; // not exposed by Lucene
     }
 
     @Override

src/main/java/org/elasticsearch/index/fielddata/plain/GeoPointBinaryDVAtomicFieldData.java

@@ -43,7 +43,7 @@ final class GeoPointBinaryDVAtomicFieldData extends AbstractAtomicGeoPointFieldD
 
     @Override
     public long ramBytesUsed() {
-        return -1; // not exposed by Lucene
+        return 0; // not exposed by Lucene
     }
 
     @Override

src/main/java/org/elasticsearch/index/fielddata/plain/NumericDVIndexFieldData.java

@@ -42,7 +42,7 @@ public NumericDVIndexFieldData(Index index, Names fieldNames, FieldDataType fiel
     public AtomicLongFieldData load(AtomicReaderContext context) {
         final AtomicReader reader = context.reader();
         final String field = fieldNames.indexName();
-        return new AtomicLongFieldData(-1) {
+        return new AtomicLongFieldData(0) {
             @Override
             public SortedNumericDocValues getLongValues() {
                 try {

src/main/java/org/elasticsearch/index/fielddata/plain/SortedNumericDVIndexFieldData.java

@@ -103,7 +103,7 @@ static final class SortedNumericLongFieldData extends AtomicLongFieldData {
         final String field;
 
         SortedNumericLongFieldData(AtomicReader reader, String field) {
-            super(-1L);
+            super(0L);
             this.reader = reader;
             this.field = field;
         }
@@ -140,7 +140,7 @@ static final class SortedNumericFloatFieldData extends AtomicDoubleFieldData {
         final String field;
 
         SortedNumericFloatFieldData(AtomicReader reader, String field) {
-            super(-1L);
+            super(0L);
             this.reader = reader;
             this.field = field;
         }
@@ -226,7 +226,7 @@ static final class SortedNumericDoubleFieldData extends AtomicDoubleFieldData {
         final String field;
 
         SortedNumericDoubleFieldData(AtomicReader reader, String field) {
-            super(-1L);
+            super(0L);
             this.reader = reader;
             this.field = field;
         }

src/main/java/org/elasticsearch/index/fielddata/plain/SortedSetDVBytesAtomicFieldData.java

@@ -56,7 +56,7 @@ public void close() {
 
     @Override
     public long ramBytesUsed() {
-        return -1; // unknown
+        return 0; // unknown
     }
 
 }