Fix comparison of identical values leads to a bug of non-effective value (#74040) (#74647)

mark-vieira · almogtavor · web-flow · commit add9a9b755b3 · 2021-06-28T11:00:00.000-07:00
Co-authored-by: Almog Tavor &lt;70065337+almogtavor@users.noreply.github.com&gt;
diff --git a/client/rest-high-level/src/main/java/org/elasticsearch/client/ml/StartDatafeedResponse.java b/client/rest-high-level/src/main/java/org/elasticsearch/client/ml/StartDatafeedResponse.java
@@ -79,8 +79,7 @@ public boolean equals(Object other) {
         }
 
         StartDatafeedResponse that = (StartDatafeedResponse) other;
-        return started == started
-            && Objects.equals(node, that.node);
+        return started == that.started && Objects.equals(node, that.node);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,7 @@ public boolean equals(Object other) {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`StartDatafeedResponse that = (StartDatafeedResponse) other;`
`82`		`- return started == started`
`83`		`- && Objects.equals(node, that.node);`
	`82`	`+ return started == that.started && Objects.equals(node, that.node);`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`@Override`