Deprecate setting index.optimize_auto_generated_id (#28862)

Author: Ke Li

server/src/main/java/org/elasticsearch/index/engine/EngineConfig.java

@@ -109,7 +109,7 @@ public final class EngineConfig {
      * The default is <code>true</code>
      */
     public static final Setting<Boolean> INDEX_OPTIMIZE_AUTO_GENERATED_IDS = Setting.boolSetting("index.optimize_auto_generated_id", true,
-        Property.IndexScope, Property.Dynamic);
+        Property.IndexScope, Property.Dynamic, Property.Deprecated);
 
     private final TranslogConfig translogConfig;
 

server/src/test/java/org/elasticsearch/index/engine/EngineConfigTests.java

@@ -0,0 +1,49 @@
+/*
+ * Licensed to Elasticsearch under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.elasticsearch.index.engine;
+
+import org.elasticsearch.Version;
+import org.elasticsearch.cluster.metadata.IndexMetaData;
+import org.elasticsearch.common.settings.Setting;
+import org.elasticsearch.common.settings.Settings;
+import org.elasticsearch.index.IndexSettings;
+import org.elasticsearch.test.ESTestCase;
+import org.elasticsearch.test.IndexSettingsModule;
+
+
+public class EngineConfigTests extends ESTestCase {
+
+    public void testOptimizeAutoGeneratedIdsSettingDeprecation() {
+        boolean optimizeAutoGeneratedIds = randomBoolean();
+        Settings.Builder builder = Settings.builder()
+            .put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT)
+            .put(EngineConfig.INDEX_OPTIMIZE_AUTO_GENERATED_IDS.getKey(), optimizeAutoGeneratedIds);
+        IndexSettings indexSettings = IndexSettingsModule.newIndexSettings("index1", builder.build());
+
+        EngineConfig config = new EngineConfig(null, null, null,
+            indexSettings, null, null, null, null,
+            null, null, null, null, null,
+            null, null, null, null, null, null,
+            null, null, null);
+
+        assertEquals(optimizeAutoGeneratedIds, config.isAutoGeneratedIDsOptimizationEnabled());
+        assertSettingDeprecationsAndWarnings(new Setting<?>[]{EngineConfig.INDEX_OPTIMIZE_AUTO_GENERATED_IDS});
+    }
+
+}