Test fix - Graph connections could appear in different orders

Graph connections could appear in different orders based on insertion sequence

Closes #33686

Author: markharwood

x-pack/plugin/core/src/test/java/org/elasticsearch/protocol/xpack/graph/GraphExploreResponseTests.java

@@ -13,6 +13,8 @@
 import org.elasticsearch.test.AbstractXContentTestCase;
 
 import java.io.IOException;
+import java.util.Arrays;
+import java.util.Comparator;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Predicate;
@@ -88,12 +90,29 @@ protected void assertEqualInstances( GraphExploreResponse expectedInstance,  Gra
         assertThat(newInstance.getTook(), equalTo(expectedInstance.getTook()));
         assertThat(newInstance.isTimedOut(), equalTo(expectedInstance.isTimedOut()));
 
+        Comparator<Connection> connComparator = new Comparator<Connection>() {
+            @Override
+            public int compare(Connection o1, Connection o2) {
+                return o1.getId().toString().compareTo(o2.getId().toString());
+            }
+        };
         Connection[] newConns = newInstance.getConnections().toArray(new Connection[0]);
         Connection[] expectedConns = expectedInstance.getConnections().toArray(new Connection[0]);
+        Arrays.sort(newConns, connComparator);
+        Arrays.sort(expectedConns, connComparator);
         assertArrayEquals(expectedConns, newConns);
 
-        Vertex[] newVertices = newInstance.getVertices().toArray(new Vertex[0]);
+        //Sort the vertices lists before equality test (map insertion sequences can cause order differences)
+        Comparator<Vertex> comparator = new Comparator<Vertex>() {
+            @Override
+            public int compare(Vertex o1, Vertex o2) {
+                return o1.getId().toString().compareTo(o2.getId().toString());
+            }
+        };
+        Vertex[] newVertices = newInstance.getVertices().toArray(new Vertex[0]);        
         Vertex[] expectedVertices = expectedInstance.getVertices().toArray(new Vertex[0]);
+        Arrays.sort(newVertices, comparator);
+        Arrays.sort(expectedVertices, comparator);
         assertArrayEquals(expectedVertices, newVertices);
 
         ShardOperationFailedException[] newFailures = newInstance.getShardFailures();

x-pack/protocol/src/test/java/org/elasticsearch/protocol/xpack/graph/GraphExploreResponseTests.java

@@ -103,8 +103,16 @@ protected void assertEqualInstances( GraphExploreResponse expectedInstance,  Gra
         assertThat(newInstance.getTook(), equalTo(expectedInstance.getTook()));
         assertThat(newInstance.isTimedOut(), equalTo(expectedInstance.isTimedOut()));
 
+        Comparator<Connection> connComparator = new Comparator<Connection>() {
+            @Override
+            public int compare(Connection o1, Connection o2) {
+                return o1.getId().toString().compareTo(o2.getId().toString());
+            }
+        };
         Connection[] newConns = newInstance.getConnections().toArray(new Connection[0]);
         Connection[] expectedConns = expectedInstance.getConnections().toArray(new Connection[0]);
+        Arrays.sort(newConns, connComparator);
+        Arrays.sort(expectedConns, connComparator);
         assertArrayEquals(expectedConns, newConns);
 
         //Sort the vertices lists before equality test (map insertion sequences can cause order differences)