Skip to content

Commit d12e644

Browse files
authored
Build: Log a warning if disabling reindex-from-old (#30304)
We disable the reindex-from-old tests if we're running on windows or in a directory that contains a space. This adds a warning to the logs when we do that so that you can tell that it happened. This will be nice to have when looking at CI and will be a hint to anyone developing locally.
1 parent 038fe11 commit d12e644

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

modules/reindex/build.gradle

+5-3
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,11 @@ dependencies {
8383
es090 'org.elasticsearch:elasticsearch:0.90.13@zip'
8484
}
8585

86-
if (Os.isFamily(Os.FAMILY_WINDOWS) || rootProject.rootDir.toString().contains(" ")) {
87-
// We can't get the pid files in windows and old versions of Elasticsearch doesn't set up the CLASSPATH correctly if there are spaces
88-
// in the path. In either case, we skip reindex-from-old.
86+
if (Os.isFamily(Os.FAMILY_WINDOWS)) {
87+
logger.warn("Disabling reindex-from-old tests because we can't get the pid file on windows")
88+
integTestRunner.systemProperty "tests.fromOld", "false"
89+
} else if (rootProject.rootDir.toString().contains(" ")) {
90+
logger.warn("Disabling reindex-from-old tests because Elasticsearch 1.7 won't start with spaces in the path")
8991
integTestRunner.systemProperty "tests.fromOld", "false"
9092
} else {
9193
integTestRunner.systemProperty "tests.fromOld", "true"

0 commit comments

Comments
 (0)