Skip to content

Commit e2ee9bc

Browse files
authored
Fix runtime jdk vendor detection used in fips.gradle (#67417)
1 parent 93d5580 commit e2ee9bc

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

buildSrc/src/main/java/org/elasticsearch/gradle/info/BuildParams.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ public void setRuntimeJavaHome(File runtimeJavaHome) {
209209
BuildParams.runtimeJavaHome = requireNonNull(runtimeJavaHome);
210210
}
211211

212-
public void setIsRutimeJavaHomeSet(boolean isRutimeJavaHomeSet) {
212+
public void setIsRuntimeJavaHomeSet(boolean isRutimeJavaHomeSet) {
213213
BuildParams.isRuntimeJavaHomeSet = isRutimeJavaHomeSet;
214214
}
215215

buildSrc/src/main/java/org/elasticsearch/gradle/info/GlobalBuildInfoPlugin.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.gradle.internal.jvm.Jvm;
3333
import org.gradle.internal.jvm.inspection.JvmInstallationMetadata;
3434
import org.gradle.internal.jvm.inspection.JvmMetadataDetector;
35+
import org.gradle.internal.jvm.inspection.JvmVendor;
3536
import org.gradle.jvm.toolchain.internal.InstallationLocation;
3637
import org.gradle.jvm.toolchain.internal.SharedJavaInstallationRegistry;
3738
import org.gradle.util.GradleVersion;
@@ -107,8 +108,9 @@ public void apply(Project project) {
107108
params.reset();
108109
params.setRuntimeJavaHome(runtimeJavaHome);
109110
params.setRuntimeJavaVersion(determineJavaVersion("runtime java.home", runtimeJavaHome, minimumRuntimeVersion));
110-
params.setIsRutimeJavaHomeSet(Jvm.current().getJavaHome().equals(runtimeJavaHome) == false);
111-
params.setRuntimeJavaDetails(getJavaInstallation(runtimeJavaHome).getDisplayName());
111+
params.setIsRuntimeJavaHomeSet(Jvm.current().getJavaHome().equals(runtimeJavaHome) == false);
112+
JvmInstallationMetadata runtimeJdkMetaData = metadataDetector.getMetadata(getJavaInstallation(runtimeJavaHome).getLocation());
113+
params.setRuntimeJavaDetails(formatJavaVendorDetails(runtimeJdkMetaData));
112114
params.setJavaVersions(getAvailableJavaVersions());
113115
params.setMinimumCompilerVersion(minimumCompilerVersion);
114116
params.setMinimumRuntimeVersion(minimumRuntimeVersion);
@@ -131,6 +133,11 @@ public void apply(Project project) {
131133
project.getGradle().getTaskGraph().whenReady(graph -> logGlobalBuildInfo());
132134
}
133135

136+
private String formatJavaVendorDetails(JvmInstallationMetadata runtimeJdkMetaData) {
137+
JvmVendor vendor = runtimeJdkMetaData.getVendor();
138+
return runtimeJdkMetaData.getVendor().getKnownVendor().name() + "/" + vendor.getRawVendor();
139+
}
140+
134141
/* Introspect all versions of ES that may be tested against for backwards
135142
* compatibility. It is *super* important that this logic is the same as the
136143
* logic in VersionUtils.java. */

gradle/fips.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import org.elasticsearch.gradle.testclusters.TestDistribution
66
if (BuildParams.inFipsJvm) {
77

88
allprojects {
9-
String javaSecurityFilename = BuildParams.runtimeJavaDetails.startsWith('Oracle') ? 'fips_java_oracle.security' : 'fips_java.security'
9+
String javaSecurityFilename = BuildParams.runtimeJavaDetails.startsWith('oracle') ? 'fips_java_oracle.security' : 'fips_java.security'
1010
File fipsResourcesDir = new File(project.buildDir, 'fips-resources')
1111
File fipsSecurity = new File(fipsResourcesDir, javaSecurityFilename)
1212
File fipsPolicy = new File(fipsResourcesDir, 'fips_java.policy')

0 commit comments

Comments
 (0)