Skip to content

Commit e697438

Browse files
double check config from v1 made it to v2, remove todo
1 parent 30d7d94 commit e697438

File tree

1 file changed

+0
-1
lines changed
  • modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3

1 file changed

+0
-1
lines changed

modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Service.java

-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ S3Client buildClient(final S3ClientSettings clientSettings, SdkHttpClient httpCl
234234
}
235235

236236
protected S3ClientBuilder buildClientBuilder(S3ClientSettings clientSettings, SdkHttpClient httpClient) {
237-
// TODO NOMERGE ensure this has all the same config features as the v1 SDK
238237
var s3clientBuilder = S3Client.builder();
239238
s3clientBuilder.httpClient(httpClient);
240239
s3clientBuilder.overrideConfiguration(buildConfiguration(clientSettings, isStateless));

0 commit comments

Comments
 (0)