Eliminate SCORE() from supported ORDER BYs

Author: costin

x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/analysis/analyzer/Verifier.java

@@ -237,10 +237,6 @@ private static boolean checkGroupByOrder(LogicalPlan p, Set<Failure> localFailur
                 Map<Expression, Node<?>> missing = new LinkedHashMap<>();
                 o.order().forEach(oe -> {
                     Expression e = oe.child();
-                    // skip score
-                    if (e instanceof Score) {
-                        return;
-                    }
                     // cannot order by aggregates (not supported by composite)
                     if (Functions.isAggregate(e)) {
                         missing.put(e, oe);

x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/analysis/analyzer/VerifierErrorMessagesTests.java

@@ -154,4 +154,9 @@ public void testGroupByOrderByFunctionOverKey() {
         assertEquals("1:44: Cannot order by non-grouped column [MAX(int)], expected [int]",
                 verify("SELECT int FROM test GROUP BY int ORDER BY MAX(int)"));
     }
+
+    public void testGroupByOrderByScore() {
+        assertEquals("1:44: Cannot order by non-grouped column [SCORE()], expected [int]",
+                verify("SELECT int FROM test GROUP BY int ORDER BY SCORE()"));
+    }
 }